adding journal entries from block not working

Bug #1222599 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon

Bug Description

This is a regression.

In Mahara 1.8 if you add a tagged journal block or recent journal block to a view the 'Add new entry' or 'new entry' option does not work.

This does however work on the full journal block.

I suspect this will be a javascript clash somewhere so will assign to myself to have a look at.

Tags: journal
Revision history for this message
Robert Lyon (robertl-9) wrote :

Added a patch for this:
https://reviews.mahara.org/#/c/2501

To test:
- have multiple jounals option off for user (user settings page)
- add taggedposts and recentposts blocktypes to a page - there should be 'new entry' buttons in the blocks.
on clicking them nothing happens
-apply patch and refresh page for js change
the buttons should now open new window for adding new journal entry

repeat the tests for user with multiple journals option on

Changed in mahara:
status: Triaged → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2501
Committed: http://gitorious.org/mahara/mahara/commit/df592e262d2a9fd94f52ce23b3fc809d62397fb3
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit df592e262d2a9fd94f52ce23b3fc809d62397fb3
Author: Robert Lyon <email address hidden>
Date: Tue Sep 17 13:25:46 2013 +1200

The journal blocktype 'new entry' button not working bug 1222599

- This was not working for tagged journal and recent journal blocktypes
clicking the button did not do anything.

- problem was a css variable expected by the js had been removed
so I added a new one that didn't clash with current css styles.

- Fixed this for when a user has only 1 journal or multiple journals

Change-Id: I19374c2c64bbf08f683871197b16e3ad37b1f6dd
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
milestone: none → 1.8.0rc1
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.8rc1 → 1.8.0
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.