Launchpad bug references in gerrit comments do not filter out period at end of sentence

[Clint Byrum]

The comment from Joe Gordon referencing bug #1221987 demonstrates the problem: https://review.openstack.org/#/c/45462/

The period at the end of the bug should not be part of the link. Most likely a regex that needs a tightened up character class or something.

[Yolanda Robla (yolanda.robla)]

I'm happy to take this bug as an initial collaboration, is ok to proceed with that?

[Elizabeth K. Joseph (lyz)]

Please do, thank you!

[Yolanda Robla (yolanda.robla)]

So problem is with linkify() method, that belongs to SafeHtmlBuilder class from com.google.gwtexpui.safehtml.client library
Actually, periods can be a valid part of an url so it's not really a problem but a particular case. Also some other can put any other sign after the launchpad bug, not limited to the case of a dot.

I managed to remove periods with a commentlink in gerrit.config:

[commentlink "launchpadbug"]
        match = <a href=\"(https://bugs\\.launchpad\\.net/[a-zA-Z0-9\\-]+/\\+bug/(\\d+))[^\"]+\">[^<]+</a>
        html = <a href=\"$1\">$1</a>

By this way we validate that launchpad bugs follow the right pattern, just stripping anything after bug number. Is ok to proceed with a fix like that in gerrit puppet file?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/55666

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/55666
Committed: http://github.com/openstack-infra/config/commit/5442230546f299949319ab0172ce0fd44144f14a
Submitter: Jenkins
Branch: master

commit 5442230546f299949319ab0172ce0fd44144f14a
Author: Yolanda Robla <email address hidden>
Date: Fri Nov 8 23:03:32 2013 +0800

    Remove extra chars in launchpad bug links

    Add a new commentlink section in gerrit.config that parses
    launchpad bug links pattern and removes any trailing char
    after the bug number, to prevent including dots, question marks
    or any other trailing char to be included in the link

    Closes-Bug: 1222217

    Change-Id: I402b75cea39cda01829bee6b1762e9abe54d85d4