trove writes sensitive credentials information in log in debug mode

[Saurabh Surana]

Trove services write credentials information in trove logs when logging is setup to debug mode.

We don't set secret flag in oslo.config.cfg, which will sanitizes the sensitive parameter while logging them.

[Saurabh Surana (saurabh-surana)]

following parameters should be set secret:

nova_proxy_admin_pass
nova_proxy_admin_tenant_name
nova_proxy_admin_user
sql_connection
dns_passkey
dns_username
rabbit_userid
rabbit_password

[Denis M. (dmakogon)]

I see what you mean, but (!) trove as fully distributed service allow user to interact with trove-api only via client without directional access to instance where api works . So, user cannot access log files or other and have no ability to read logs. So it is not necessay to make this this parameters secured.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/45985

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/45985
Committed: http://github.com/openstack/trove/commit/f1661b7791ee5cef346b416e8488504ae3aa86a2
Submitter: Jenkins
Branch: master

commit f1661b7791ee5cef346b416e8488504ae3aa86a2
Author: Vipul Sabhaya <email address hidden>
Date: Tue Sep 10 18:07:31 2013 -0700

    Mark sensitive cfg options with secure flag

    * Marks sensitive cfg options with the secure attribute
      which prevents them from being logged in the clear

    fixes bug#1221902

    Change-Id: I86887e58f3fc11cdbbe95d90da9458143c70ec67

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/46374

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/46374
Committed: http://github.com/openstack/trove/commit/d686c48910f0966b2d64f7055d5956c55b9501c9
Submitter: Jenkins
Branch: milestone-proposed

commit d686c48910f0966b2d64f7055d5956c55b9501c9
Author: Vipul Sabhaya <email address hidden>
Date: Tue Sep 10 18:07:31 2013 -0700

    Mark sensitive cfg options with secure flag

    * Marks sensitive cfg options with the secure attribute
      which prevents them from being logged in the clear

    fixes bug#1221902

    Change-Id: I86887e58f3fc11cdbbe95d90da9458143c70ec67
    (cherry picked from commit f1661b7791ee5cef346b416e8488504ae3aa86a2)