Character in legend of fig2, p697 of Saux_etal_2003 (probably the gamma) crashes STK and erase everything in the phyml

Bug #1221818 reported by Cyrille Delmer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Supertree Toolkit
Fix Released
Critical
Jon Hill

Bug Description

Character in legend of fig2, p697 of Saux_etal_2003 (probably the gamma) crashes STK and erase everything in the phyml

Jon Hill (jon-hill)
Changed in supertree-toolkit:
status: New → Confirmed
importance: Undecided → Critical
assignee: nobody → Jon Hill (jon-hill)
milestone: none → beta
Revision history for this message
Jon Hill (jon-hill) wrote :

Current code simply tries to save - if the save fails, then the file may have already been altered. I've altered this to do the following:
 - save to a tmp file
 - if successful, copy the existing file to filname.phyml.bak
 - copy tmp file to filename.phyml

You will therefore always have a version of the file, regardless of which stage failed (either the original, the original.bak or -- hopefully! -- the new one)

The error with the Gamma still needs addressing.

Changed in supertree-toolkit:
status: Confirmed → In Progress
Revision history for this message
Jon Hill (jon-hill) wrote :

I can't replicate the error on my computer - the figure legend (given to me separately) saves fine.

"Single tree inferred under maximum likelihood search with a GTR-⌫ model of sequence evolution. All parameters
used in the model were estimated using maximum likelihood. Values above the branches represent bootstrap percentages
Ͼ50%."

The Gamma symbol is the odd X-thing above. This also appears in the XML file.

Need to try on other machines to replicate this.

Revision history for this message
Jon Hill (jon-hill) wrote :

Fixed via saving to temp file first *and* making a back up. If it crashes, the data is now safe.

Changed in supertree-toolkit:
status: In Progress → Fix Committed
Revision history for this message
Jon Hill (jon-hill) wrote :

Fixed in r119

Jon Hill (jon-hill)
Changed in supertree-toolkit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.