add a True/False to --can-share under glance memeber-create

[Dafna Ron]

currently, to add or remove --can-share for glance member-create command we run it with --can-share for True and without the --can-share for false.

since when we list the members of an image we would see True/False in the can share info, I think that this command should be inline with all other commands that have a True/False param and that this command should be run as 'glance member-create <image> <tenant> --can-share True/False.

[Feilong Wang (flwang)]

Hi Dafna, may I know why you want a explicit Flase? Since False is a default value of can-share, see https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v1/image_members.py#L83
That means if you don't specify the argument, the default value is False.

[Dafna Ron (dron-3)]

that is not what I think we should change here.
what I want is for this command to be synced with other commands in openstack.
so if we add --can-share we need to specify True/False.
if we don't add anything it will be a default False like it is now.

currently, to change the True/False param we use --can-share True for adding it and running the command without any --can-share if we want to remove it and this is a bit confusing... not that a user cannot reach the solution on his/her own and run the command without the --can-share, but its not synced to how other commands in openstack work.

[Flavio Percoco (flaper87)]

@Dafna, I get your consistency concerns and I agree with you. However, I'd rather change other boolean flags to behave like `--can-share` instead of changing `--can-share`.

CLI boolean flags aren't suppose to have values.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167568

[OpenStack Infra (hudson-openstack)]

Change abandoned by yatin (<email address hidden>) on branch: master
Review: https://review.openstack.org/167568
Reason: Abandon change till 1.0.0 release, after that we should think about behaviour of all boolean flag.

[yatin (yatinkarel)]

@Flavio, changing other options to behave like boolean flags, check the proposed solution.

[yatin (yatinkarel)]

Fix proposed to branch: master
Review: https://review.openstack.org/170781

[OpenStack Infra (hudson-openstack)]

Change abandoned by Glance Bot (<email address hidden>) on branch: master
Review: https://review.openstack.org/170781

[Ian Cordasco (icordasc)]

This was proposed to be closed nearly two years ago. It's an inconsistency, but at this point it would be far too difficult to change in a backwards compatible manner. Marking this won't fix as a result of the inactivity and backwards incompatibility