v3 server's rebuild with access_ip_* doesn't work for xml format

Bug #1221646 reported by Alex Xu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Alex Xu

Bug Description

        if node.hasAttribute("access_ipv4"):
            rebuild["access_ip_v4"] = node.getAttribute("access_ip_v4")

        if node.hasAttribute("access_ipv6"):
            rebuild["access_ip_v6"] = node.getAttribute("access_ip_v6")

access_ipv4 should be access_ip_v4

We can't merge this patch https://review.openstack.org/#/c/41349/
So we need fix current code.

Tags: api
Alex Xu (xuhj)
tags: added: api
Changed in nova:
assignee: nobody → Alex Xu (xuhj)
status: New → Triaged
Alex Xu (xuhj)
Changed in nova:
importance: Undecided → High
milestone: none → havana-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/45421

Changed in nova:
status: Triaged → In Progress
Alex Xu (xuhj)
Changed in nova:
milestone: havana-rc1 → none
status: In Progress → Won't Fix
Alex Xu (xuhj)
Changed in nova:
status: Won't Fix → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/45421
Committed: http://github.com/openstack/nova/commit/9501fa954b4d724b665207c2a0188e92f691fdfb
Submitter: Jenkins
Branch: master

commit 9501fa954b4d724b665207c2a0188e92f691fdfb
Author: He Jie Xu <email address hidden>
Date: Fri Sep 6 20:48:48 2013 +0800

    Fix v3 server rebuild deserializer checking with wrong access_ip key

    When rebuild server with xml format, the xml deserializer code
    are checking with wrong key. So rebuilding with access_ips doesn't
    make any effect. So correct the wrong key 'access_ipv4', 'access_ipv6'
    to 'access_ip_v4', 'access_ip_v6'.

    Change-Id: I8fccf3727f193bf9142dc814a76a32d5ab1a1b0a
    Closes-bug: #1221646

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.