NotImplementedError is a Python built-in exception

Bug #1221500 reported by Henry Gessau
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
ZhiQiang Fan

Bug Description

$ git grep \\.NotImplementedError
neutron/extensions/l3.py:288: raise qexception.NotImplementedError()
neutron/extensions/l3.py:291: raise qexception.NotImplementedError()
neutron/plugins/nicira/NeutronPlugin.py:1091: raise q_exc.NotImplementedError(_("admin_state_up=False "

Revision history for this message
ZhiQiang Fan (aji-zqfan) wrote :

Actually, there is no NotImplementedError defined in neutron.common.exceptions

Changed in neutron:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/45374

Changed in neutron:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/45374
Committed: http://github.com/openstack/neutron/commit/0739b2fe827b3beefb5ad81c063cbc4d00525a9d
Submitter: Jenkins
Branch: master

commit 0739b2fe827b3beefb5ad81c063cbc4d00525a9d
Author: ZhiQiang Fan <email address hidden>
Date: Fri Sep 6 13:27:19 2013 +0800

    Fix incorrect NotImplementedError

    neutron.common.exceptions doesn't define NotImplementedError, but
    some codes still use it. We should use builtin
    exceptions.NotImplementedError instead.

    Note: this patch also fixes a never run code in nvp.

    Closes-Bug: #1221500
    Change-Id: I5f367ab5edc1e7fbbc2e4eba5fe36d148d4d062d

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → havana-rc1
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.