PCI Device object improperly ignores missing db_object fields

[Dan Smith]

In PCIDevice._from_db_object():

  pci_device[key] = db_dev.get(key)

This makes the method ignore missing database object keys, which prevents the strict typechecking from doing it's job, and differs from every other object model currently in the tree. As a result, non-nullable attributes such as dev_type are string-converted to "None" in the object, which is definitely not the intent.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/45297

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/45297
Committed: http://github.com/openstack/nova/commit/72ea0b76657a0f574ae6b17617ac560f2dbde0d9
Submitter: Jenkins
Branch: master

commit 72ea0b76657a0f574ae6b17617ac560f2dbde0d9
Author: Dan Smith <email address hidden>
Date: Thu Sep 5 10:41:57 2013 -0700

    Fix PCIDevice ignoring missing DB attributes

    Right now, the PCIDevice _from_db_object() method ignores missing
    attributes on the DB object by using get(). This prevents the strict
    typechecking from doing it's job, and differs from every other object
    model currently in the tree. As a result, non-nullable attributes such
    as dev_type are string-converted to "None" in the object, which is
    definitely not the intent.

    This is convention, not something we test for, but it was wrong, and
    ended up breaking the next patch which introduces a scenario where this
    gets checked in the unit tests more strictly. Thus, the test is in the
    next aptch

    Change-Id: Id6e1f444ceae13ee9fa1a9518db5a239a1d9fbe3
    Closes-bug: 1221360