app.published_json is not updated when an app is deleted

[Vincent Ladeuil]

This came up while writing devportal.tests.test_clickapp_user_stories.ClickUserStoriesInvolvingClickPackageIndex.test_delete_app:

    def test_delete_app(self):
        app = self.factory.makeClickPackage(registrant=self.developer._user,
                                            state="Published")
        # Make sure we have the right app in click-package-index
        app.update_click_index()
        resp = self.developer.application_delete(app, data=dict(confirm=True))
        # A narrower check would be better
        self.assertEqual(200, resp.status_code)
        # Since we don't use USE_CLICK_UPDOWN_STATUS_API we succeed to delete
        # the app.
        self.assertContains(resp,
                            'Your application has been permanently deleted.')
        refreshed = get_refreshed_app_json(app)
        # The json part is not updated and as such still mentions 'Published'
        self.assertEqual('Published', refreshed['status'])
        # But the model rightly sees the deletion
        refreshed_app = models.ClickPackage.objects.get(pk=app.id)
        self.assertEqual('Deleted', refreshed_app._state_token)