Nova notifier error TypeError: _from_db_object() got multiple values for keyword argument 'expected_attrs'

Bug #1221173 reported by Julien Danjou
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Critical
Julien Danjou

Bug Description

All tests fail and block the gate:

======================================================================
FAIL: test_notifier.TestNovaNotifier.test_correct_gatherer
tags: worker-1
----------------------------------------------------------------------
pythonlogging:'': {{{Loading compute driver 'nova.virt.fake.FakeDriver'}}}

Traceback (most recent call last):
  File "/home/jd/Source/ceilometer/.tox/py27/local/lib/python2.7/site-packages/mock.py", line 1201, in patched
    return func(*args, **keywargs)
  File "/home/jd/Source/ceilometer/nova_tests/test_notifier.py", line 172, in setUp
    expected_attrs=['metadata', 'system_metadata'])
TypeError: _from_db_object() got multiple values for keyword argument 'expected_attrs'
======================================================================

Julien Danjou (jdanjou)
Changed in ceilometer:
status: New → Confirmed
importance: Undecided → Critical
assignee: nobody → Julien Danjou (jdanjou)
milestone: none → havana-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/45222

Changed in ceilometer:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/45222
Committed: http://github.com/openstack/ceilometer/commit/d2a87a9dfd3cd9ef034eed3d693683972c842576
Submitter: Jenkins
Branch: master

commit d2a87a9dfd3cd9ef034eed3d693683972c842576
Author: Julien Danjou <email address hidden>
Date: Thu Sep 5 14:39:54 2013 +0200

    nova_notifier: fix tests

    The prototype for instance_update_and_get_original changed, so let's
    ignore it completely for the future.

    Change-Id: Icfa161109e76e2717f64084ddce829f6c68aeb57
    Fixes-Bug: #1221173

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/45266

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/45331

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/45384

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (milestone-proposed)

Reviewed: https://review.openstack.org/45384
Committed: http://github.com/openstack/ceilometer/commit/774513b52e16abdf16f61032ae462d52488e92ff
Submitter: Jenkins
Branch: milestone-proposed

commit 774513b52e16abdf16f61032ae462d52488e92ff
Author: Julien Danjou <email address hidden>
Date: Thu Sep 5 12:50:03 2013 +0400

    Fix wrong migrations and fix tests in nova_notifier

    This is a joint commit of 2 other commits from master:

    For Postgres migrations are failed.
    More then we can get for mysql an error
    "Specified key was too long; max key length is 1000 bytes" in b6ae66d05e3
    migration in some versions of dialect.
    Fixes-Bug: #1219776
    (cherry-picked from aae3f55304ff161b401b803769350e9cb66b0e8c)

    The prototype for instance_update_and_get_original changed, so let's
    ignore it completely for the future.
    Fixes-Bug: #1221173
    (cherry-picked from d2a87a9dfd3cd9ef034eed3d693683972c842576)

    Change-Id: Id4d349bbc49cdc957076b3e211f70db9838cd4cb

Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.