PXE dhcp_option needs to provide the bootfile_name

[dkehn]

in the nova/virt/baremetal/driver.py the call to pxe.py pxe.get_pxe_config_file_path(instance) need to return the bootfile name not the path.

Line 84 reads only my_ip from nova conf. But, bootfile_path in line 512 (bootfile_path = self.driver.get_pxe_config_file_path(instance)) is getting set from pxe.py which is getting the value “/tftpboot/<instance-id>/config”. This value should actually be “pxelinux.0” (or absolute location of pxelinux.0) . baremetal does not find the bootfile in “/tftpboot/<instance-id>/config”, it finds it in /tftpboot/pxelinux.0 (where tftproot=/tftpboot set in nova.conf).

In pxe.py,
def get_pxe_config_file_path(instance):
    """Generate the path for an instances PXE config file."""
    return os.path.join(CONF.baremetal.tftp_root, instance['uuid'], 'config')

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/45126

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/45126
Committed: http://github.com/openstack/nova/commit/d61eb32eeeaf213912383fb14bf86f2511518943
Submitter: Jenkins
Branch: master

commit d61eb32eeeaf213912383fb14bf86f2511518943
Author: dekehn <email address hidden>
Date: Wed Sep 4 14:58:57 2013 -0600

    Fix the bootfile_name method call in baremetal

    nova baremetal was supplying a pxelinux config file disk path, but
    PXE clients need the binary to bootstrap, which is neither the config
    file, nor a filesystem path - it's a path within TFTP server.

    As some environments/architectures may have different PXE binary,
    this needs to be an option.

    DocImpact

    Change-Id: I393552ae2d45e1ff5bc306fc8717fa4265ac827f
    Closes-Bug: #1220904