inconsistent i18n message

Bug #1220813 reported by Kun Huang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Kun Huang

Bug Description

in cinder/exception.py: https://github.com/openstack/cinder/blob/master/cinder/exception.py#L242

message = _("Invalid metadata") + ": %(reason)s"

is not consistent i18n usage. In most of cases, we use _() for whole string instead of leaving something out.

More than inconsistent, some text in leaving strings may be not translated, for example, ':' in English is different ':' in Chinese.

Changed in cinder:
assignee: nobody → Kun Huang (academicgareth)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/45081

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/45081
Committed: http://github.com/openstack/cinder/commit/193ad7994d536f644d73849512b574d4f5ee7546
Submitter: Jenkins
Branch: master

commit 193ad7994d536f644d73849512b574d4f5ee7546
Author: Kun Huang <email address hidden>
Date: Thu Sep 5 00:36:48 2013 +0800

    fix inconsistent i18n log message

    An inconsistent example:
        imessage = _("Invalid metadata") + ": %(reason)s"
    This is not consistent i18n usage. In most of cases, we use _() for
    whole string instead of leaving something out.

    More than inconsistent, some text in leaving strings may be not
    translated, for example, ':' in English is different ':' in Chinese.

    Change-Id: I00e690021c44f1debbe034cc0837a07b292ffd1b
    Closes-Bug: #1220813

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → havana-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.