help for image-update is incorrect

Bug #1220809 reported by Dafna Ron
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
Undecided
Abhishek Talwar
Nominated for Kilo by Erno Kuvaja

Bug Description

I tried updating and image with --location.
we get this output:

[root@opens-XXXX~(keystone_admin)]# glance image-update dc79349e-de25-4ec5-8b12-5a6145270c47 --location http://XXXX
Request returned failure status.
400 Bad Request
Attempted to update Location field for an image not in queued status.
    (HTTP 400)

this is what it says on help print:

 --location <IMAGE_URL>
                        URL where the data for this image already resides. For
                        example, if the image data is stored in swift, you
                        could specify
                        'swift://account:<email address hidden>/container/obj'.

this should be change.
we cannot change the location unless the image is queued and even then only if all params exists:

Request returned failure status.
400 Bad Request
Invalid disk format 'None' for image.
    (HTTP 400)

same issue for copy-from:

[root@opens-xxxx ~(keystone_admin)]# glance image-update dc79349e-de25-4ec5-8b12-5a6145270c47 --copy-from http://XXXX
Request returned failure status.
400 Bad Request
Attempted to update Location field for an image not in queued status.
    (HTTP 400)

affects: glance → python-glanceclient
Changed in python-glanceclient:
assignee: nobody → anju Tiwari (anjutiwari5)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/52008

Changed in python-glanceclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/52011

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/61918

Changed in python-glanceclient:
assignee: anju Tiwari (anjutiwari5) → Abhishek Talwar (abhishek-talwar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/157347

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/157347
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=6d864ef65c73905370fe9c817fb81b262714bd2d
Submitter: Jenkins
Branch: master

commit 6d864ef65c73905370fe9c817fb81b262714bd2d
Author: Abhishek Talwar <email address hidden>
Date: Thu Feb 19 17:34:33 2015 +0530

    Correct help messages for image-update command

    Currently when you are trying to update the location of an image which
    is not in queued status you will get an error from the Glance API. The
    help message for --location and --copy-from arguments should be updated
    to inform the user that it works only for images in queued status.

    Co-Authored-By: Abhishek Talwar <email address hidden>
    Co-Authored-By: Kamil Rykowski <email address hidden>

    Change-Id: I82b14ffde3f301d7ffef68e984ba4ad2ae0f8b0f
    Closes-Bug: #1220809

Changed in python-glanceclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/199541

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (stable/kilo)

Reviewed: https://review.openstack.org/199541
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=e9b2b4ec11ed4955e61295d0fd5ae6b012a2c65d
Submitter: Jenkins
Branch: stable/kilo

commit e9b2b4ec11ed4955e61295d0fd5ae6b012a2c65d
Author: Abhishek Talwar <email address hidden>
Date: Thu Feb 19 17:34:33 2015 +0530

    Correct help messages for image-update command

    Currently when you are trying to update the location of an image which
    is not in queued status you will get an error from the Glance API. The
    help message for --location and --copy-from arguments should be updated
    to inform the user that it works only for images in queued status.

    Co-Authored-By: Abhishek Talwar <email address hidden>
    Co-Authored-By: Kamil Rykowski <email address hidden>

    Change-Id: I82b14ffde3f301d7ffef68e984ba4ad2ae0f8b0f
    Closes-Bug: #1220809
    (cherry picked from commit 6d864ef65c73905370fe9c817fb81b262714bd2d)

tags: added: in-stable-kilo
Changed in python-glanceclient:
milestone: none → 1.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.