Ubuntu
unity8 package

Spinner should be shown when opening a preview if it's not instant

Bug #1220651 reported by Diego Sarmentero
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity8 (Ubuntu)
Fix Released
High
Michael Zanetti

Bug Description

When loading a preview that requires to check some webservices, wait for dbus replies or something, a Spinner or some kind of visual help should be provided so the user knows that something is happening and the answer is going to be available soon, instead of seeing the ui as nothing happened and keep pressing in the buttons.

Related branches

lp:~mzanetti/unity8/switching-previews
Superseded for merging into lp:unity8
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Michal Hruby: Pending requested
Michał Sawicz: Pending requested
Oren Horev: Pending (design) requested
Diff: 724 lines (+309/-81)
11 files modified
Components/Carousel.qml (+23/-7)
Components/FilterGrid.qml (+3/-0)
Components/ResponsiveGridView.qml (+10/-0)
Components/Tile.qml (+7/-0)
Dash/Apps/AppPreview.qml (+9/-0)
Dash/DashPreview.qml (+1/-3)
Dash/DashPreviewPlaceholder.qml (+25/-0)
Dash/Generic/GenericFilterGrid.qml (+4/-6)
Dash/GenericScopeView.qml (+217/-59)
Dash/SearchableResultModel.qml (+4/-0)
tests/qmltests/Dash/tst_GenericScopeView.qml (+6/-6)
lp:~unity-team/unity8/switching-previews
PS Jenkins bot (community): Approve (continuous-integration)
Albert Astals Cid (community): Approve
Michał Sawicz: Needs Fixing
Michal Hruby (community): Approve
Oren Horev: Pending (design) requested
Diff: 1364 lines (+516/-243)
24 files modified
Components/Carousel.qml (+27/-9)
Components/FilterGrid.qml (+3/-0)
Components/LazyImage.qml (+2/-2)
Components/PageHeader.qml (+4/-0)
Components/ResponsiveGridView.qml (+10/-0)
Components/Tile.qml (+9/-0)
Dash/Apps/AppPreview.qml (+9/-0)
Dash/Apps/ApplicationsFilterGrid.qml (+14/-5)
Dash/Apps/DashPluginFilterGrid.qml (+2/-4)
Dash/DashPreview.qml (+1/-3)
Dash/DashPreviewPlaceholder.qml (+25/-0)
Dash/Generic/GenericFilterGrid.qml (+4/-6)
Dash/Generic/WeatherFilterGrid.qml (+2/-4)
Dash/GenericScopeView.qml (+227/-66)
Dash/Music/AlbumTile.qml (+0/-116)
Dash/Music/MusicFilterGrid.qml (+2/-4)
Dash/SearchableResultModel.qml (+4/-0)
Dash/Video/VideoFilterGrid.qml (+2/-4)
tests/mocks/Unity/fake_preview.cpp (+9/-1)
tests/mocks/Unity/fake_preview.h (+2/-0)
tests/mocks/Unity/fake_scope.cpp (+25/-4)
tests/mocks/Unity/fake_scope.h (+7/-2)
tests/mocks/Unity/fake_unity_plugin.cpp (+3/-0)
tests/qmltests/Dash/tst_GenericScopeView.qml (+123/-13)
lp:ubuntu/trusty-proposed/unity8
Daniel Holbach (dholbach)
tags: added: appstore
Michał Sawicz (saviq)
Changed in unity8:
status: New → Triaged
importance: Undecided → High
Michał Sawicz (saviq)
Changed in unity8:
assignee: nobody → Michael Zanetti (mzanetti)
Michał Sawicz (saviq)
Changed in unity8:
milestone: none → ubuntu-13.09
Michał Sawicz (saviq)
Changed in unity8:
status: Triaged → In Progress
Michal Hruby (mhr3)
summary: - It should show a spinner or something between previews transition when
- loading a preview is not instant
+ Spinner should be shown when opening a preview if it's not instant
Michał Sawicz (saviq)
Changed in unity8:
milestone: ubuntu-13.09 → ubuntu-13.10
Michael Zanetti (mzanetti)
tags: added: needs-test
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity8 at revision 493, scheduled for release in unity8, milestone phone-v1-freeze

Changed in unity8:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 7.83+14.04.20131105.1-0ubuntu1

---------------
unity8 (7.83+14.04.20131105.1-0ubuntu1) trusty; urgency=low

  [ Michał Sawicz ]
  * Implement switching between previews by swiping. (LP: #1220651,
    #1088572)

  [ Nick Dedekind ]
  * Faster loading of indicator menus. (LP: #1226650)

  [ Albert Astals ]
  * Make sure we have ssh started when we need it .
  * Fix a few warnings in DashContent.qml on shutdown
    Dash/DashContent.qml:119: TypeError: Cannot read property
    'previewShown' of null Dash/DashContent.qml:120: TypeError: Cannot
    read property 'moving' of null .
  * Don't use deprecated Panel methods.

  [ Christopher Lee ]
  * Adds an easy to consume function that attempts to unlock the unity
    greeter. (LP: #1240261)

  [ Lars Uebernickel ]
  * Indicators: add TimeFormatter and use it in the messaging menu This
    component can be used to turn a timestamp and a format string into a
    string with the corresponding time and format. The string will
    change whenever the timezone changes. (LP: #1236413)

  [ Andrea Cimitan ]
  * Allow drag over bounds, but not overshoot. (LP: #1204300)
  * Threshold to activate the left edge swipe to reveal dash is now 26
    GU. (LP: #1236286)

  [ Michael Zanetti ]
  * replace the launcher quicklist's Popover with an own quicklist
    implementation The Popover probably won't ever support what the
    launcher needs.
  * Implement switching between previews by swiping. (LP: #1220651,
    #1088572)
  * don't trigger the greeter teasing during a movement of the greeter.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 495
 -- Ubuntu daily release <email address hidden> Tue, 05 Nov 2013 12:22:04 +0000

Changed in unity8 (Ubuntu):
status: New → Fix Released
Michał Sawicz (saviq)
Changed in unity8:
status: Fix Committed → Fix Released
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
assignee: nobody → Michael Zanetti (mzanetti)
importance: Undecided → High
no longer affects: unity8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.