Open folder of the document

Bug #1220586 reported by sojusnik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qpdfview
Fix Released
Wishlist
Adam Reichold

Bug Description

Hi!

It would be very useful, if the toolbar could have an icon, that opens the folder of the current document or tab respectively.

Thanks!

Related branches

Revision history for this message
Adam Reichold (adamreichold) wrote :

Hello again,

Whether it makes sense to implements this depends mainly on how well-integrated launching the user's default file manager to open the folder is in Qt. I'll investigate this and report back here.

Best regards, Adam.

Changed in qpdfview:
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Adam Reichold (adamreichold) wrote :

There is now a branch lp:~adamreichold/qpdfview/open-folder which contains an implementation. Please test and report.

Changed in qpdfview:
status: Triaged → In Progress
assignee: nobody → Adam Reichold (adamreichold)
milestone: none → 0.4.6
Revision history for this message
sojusnik (sojusnik) wrote :

I'm sorry, I don't know how to install this branch. My coding skills are very limited.

Revision history for this message
Adam Reichold (adamreichold) wrote :

There are two ways to go forward:
* If you're comfortable with building from source: Fetch the branch's code using Bazaar and build it yourself for testing purposes.
* If you're not comfortable with building from source: Wait until the branch is merged into trunk (after the release of version 0.4.5) and try out the dailydebs available at [1].

In either case, if you have any difficulties, ask for assistance on the mailing list. (By the way, if you make yourself a (temporary) member of the qpdfview group on Launchpad, your messages to mailing list don't need to be approved by me and you will probably get help by someone else faster.)

[1] https://code.launchpad.net/~adamreichold/+archive/qpdfview-dailydeb

Revision history for this message
sojusnik (sojusnik) wrote :

I'll prefer the latter.

Thank you!

Revision history for this message
Adam Reichold (adamreichold) wrote :

I changed the branch to move the action into the tab bar context menu since I don't think it should be handled on the same level as action like open or refresh. This also allows to open the folder containing any open tab, not just the current one.

Changed in qpdfview:
status: In Progress → Fix Committed
Revision history for this message
Ari (ari-lp) wrote :

Thanks for adding this option, Adam. This was something I was looking for as well.

Unfortunately by moving this action to the tab context menu you inadvertently made it impossible to open the parent folder when only one document is open. To solve this I would propose to add a classic action in addition to the existing context menu entry.

Cheers
-- Ari

Revision history for this message
Adam Reichold (adamreichold) wrote : Re: [Bug 1220586] Re: Open folder of the document

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello again,

Am 24.09.2013 14:40, schrieb Ari:
> Thanks for adding this option, Adam. This was something I was
> looking for as well.
>
> Unfortunately by moving this action to the tab context menu you
> inadvertently made it impossible to open the parent folder when
> only one document is open. To solve this I would propose to add a
> classic action in addition to the existing context menu entry.

I unterstand the problem, but since I really don't wan't this to
clutter the menu or tool bar, I just moved it into the document view
instead of the tab bar context menu. (Since this is really not a core
PDF viewer function, just a nicety.)

> Cheers -- Ari
>

Best regards, Adam.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (GNU/Linux)

iQEcBAEBAgAGBQJSQdc9AAoJEPSSjE3STU34zfoIAJptSwQOgYZ02I3yi+q0SNrZ
WCn1Y4gTWOY74SprecfIyRFAWqmPP514YL1kVg720DvwJDrqsswp/DYzgcoUdjEm
Wtvliri6OmvUTrvn/62gci/Xay/XgAs38b1RNw7eeptPajV3N4yQ5XTfKRByrF1o
sSUaT0JHTH0Gi/T+dkAuhwA+KGZ+eZfcAoVkGXJM6b5QvachOG4kGQEgxKJTxavZ
aJToDbaih82Ec2gxcX486LDHeanxFqDBGa7dRHfUJSoXW5VOPNJYDFschx3F+Q9W
yT9EpAyt3W/H7jyQawXMeLfKucGqIsZ7MlDQTh8BYH0muANZbmi/DmP1ozOZc+A=
=Qmca
-----END PGP SIGNATURE-----

Revision history for this message
Ari (ari-lp) wrote :

I see your point, Adam. I am absolutely fine with having it in the document context menu. Thanks for getting onto this right away!

Changed in qpdfview:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.