nova service should be enabled by default

[Dan Bode]

Currently, the nova services are disabled by default.

This is counter-intuitive and inconsistent with the other openstack puppet modules.

If a user includes a class, then it should result in its service being enabled.

[Dan Bode (bodepd)]

the change for this is easy enough to make, but it will result in backwards compatibility breakage.

[Mathieu Gagné (mgagne)]

I don't mind backward compatibility being broken.

This is my reasoning:
- People wishing to have nova-conductor installed and "enabled" (or any other service affected by this behaviour) are already adding enabled => true to have it enabled (to override the default value).
- People wishing to NOT have nova-conductor installed and "enabled" won't use the class in the first place.

[Dan Bode (bodepd)]

The enalbed flags were initially added to support service in an active/passive model. I am pretty sure that at least someone is using them for this purpose.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/184570

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/184656

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/186887

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/186933

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/186955

[Bogdan Dobrelya (bogdando)]

>The enalbed flags were initially added to support service in an active/passive model. I am pretty sure that at least someone is using them for this purpose.

Yes, for example, operators may want nova-compute service disabled on puppet runtime stage when scaling compute nodes horizontally as the nodes may not be ready yet to accept workloads.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthew Kirby (<email address hidden>) on branch: master
Review: https://review.openstack.org/186887
Reason: https://review.openstack.org/#/c/184656/ is the correct link.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthew Kirby (<email address hidden>) on branch: master
Review: https://review.openstack.org/186955
Reason: https://review.openstack.org/#/c/184656/ is the correct change id.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthew Kirby (<email address hidden>) on branch: master
Review: https://review.openstack.org/184570
Reason: https://review.openstack.org/#/c/184656/ is the correct change id.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/184656
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=895e057abbb743a55c612afd28208821957a1286
Submitter: Jenkins
Branch: master

commit 895e057abbb743a55c612afd28208821957a1286
Author: <email address hidden> <email address hidden>
Date: Wed May 20 11:02:10 2015 -0700

    Enable nova service by default

    This commit updates the default value for enable for nova components to
    default to true, instead of false. Without this
    change the nova service is not enabled by default resulting in a
    different behavior than with other puppet openstack modules.
    Associated tests are updated to expect the change in defaults.

    Co-Authored-By: Cody Herriges <email address hidden>
    Change-Id: I49fc84f9fedfe00d7846441e1b49334abb09e0eb
    Closes-bug: #1220473

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/186933
Reason: This review is > 4 weeks without comment or failed Jenkins or merge conflict the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.