Mir

acceptance test failures (android)

Bug #1220443 reported by Kevin DuBois
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Kevin DuBois
Mir 0.0.13
mir (Ubuntu)
Fix Released
High
Unassigned

Bug Description

multiple failures on nexus4 acceptance tests (mir rev 1050) seems to be ok on desktop

root@ubuntu-phablet:/root# [ RUN ] DefaultDisplayServerTestFixture.client_library_connects_and_disconnects
./acceptance-tests | grep FAIL
[ FAILED ] DefaultDisplayServerTestFixture.client_library_creates_surface (31 ms)
[ FAILED ] DefaultDisplayServerTestFixture.surface_types (29 ms)
[ FAILED ] DefaultDisplayServerTestFixture.client_can_set_surface_state (43 ms)
[ FAILED ] DefaultDisplayServerTestFixture.client_receives_surface_state_events (51 ms)
[ FAILED ] DefaultDisplayServerTestFixture.client_library_creates_multiple_surfaces (46 ms)
[ FAILED ] DefaultDisplayServerTestFixture.client_library_accesses_and_advances_buffers (25 ms)
[ FAILED ] DefaultDisplayServerTestFixture.fully_synchronous_client (25 ms)
[ FAILED ] DefaultDisplayServerTestFixture.highly_threaded_client (26 ms)
[ FAILED ] DefaultDisplayServerTestFixture.ClientLibraryThreadsHandleNoSignals (27 ms)
[ FAILED ] DefaultDisplayServerTestFixture.MultiSurfaceClientTracksBufferFdsCorrectly (31 ms)

(hang)
DefaultDisplayServerTestFixture.creates_surface_of_correct_size

Related branches

lp:~kdub/mir/fix-1220443
PS Jenkins bot (community): Approve (continuous-integration)
Alan Griffiths: Approve
Daniel van Vugt: Pending requested
Robert Carr: Pending requested
Diff: 988 lines (+361/-119)
18 files modified
include/test/mir_test_framework/display_server_test_fixture.h (+2/-0)
include/test/mir_test_framework/stub_client_connection_configuration.h (+35/-0)
include/test/mir_test_framework/testing_client_configuration.h (+43/-0)
include/test/mir_test_framework/testing_process_manager.h (+7/-8)
src/client/mir_client_library.cpp (+39/-17)
tests/acceptance-tests/test_client_authorization.cpp (+7/-0)
tests/acceptance-tests/test_client_focus_notification.cpp (+2/-9)
tests/acceptance-tests/test_client_input.cpp (+8/-15)
tests/acceptance-tests/test_client_library.cpp (+30/-17)
tests/acceptance-tests/test_focus_selection.cpp (+2/-9)
tests/acceptance-tests/test_server_shutdown.cpp (+2/-9)
tests/acceptance-tests/test_shell_control_of_surface_configuration.cpp (+2/-9)
tests/acceptance-tests/test_surfaceloop.cpp (+3/-10)
tests/acceptance-tests/test_surfaces_with_output_id.cpp (+2/-9)
tests/mir_test_framework/CMakeLists.txt (+1/-0)
tests/mir_test_framework/display_server_test_fixture.cpp (+9/-6)
tests/mir_test_framework/testing_client_options.cpp (+126/-0)
tests/mir_test_framework/testing_process_manager.cpp (+41/-1)
Robert Carr (community): Abstain
Alan Griffiths: Needs Fixing
PS Jenkins bot (community): Approve (continuous-integration)
Daniel van Vugt: Approve
Diff: 491 lines (+301/-28)
9 files modified
include/test/mir_test_framework/display_server_test_fixture.h (+5/-0)
include/test/mir_test_framework/testing_client_configuration.h (+57/-0)
include/test/mir_test_framework/testing_process_manager.h (+1/-7)
src/client/mir_client_library.cpp (+39/-17)
tests/acceptance-tests/test_client_authorization.cpp (+3/-0)
tests/acceptance-tests/test_client_library.cpp (+6/-0)
tests/mir_test_framework/CMakeLists.txt (+1/-0)
tests/mir_test_framework/display_server_test_fixture.cpp (+8/-4)
tests/mir_test_framework/testing_client_options.cpp (+181/-0)
Revision history for this message
Kevin DuBois (kdub) wrote :

this is due to the hardware HAL mocks being loaded incorrectly in the acceptance tests. tests pass (with the exception of the nested display tests) if we load the real HAL.

should not affect real server

Revision history for this message
Kevin DuBois (kdub) wrote :

I have a temporary fix here: lp:~kdub/mir/fix-1220443 (manipulating mock hal object's linking), however, a proper solution would be for the client side to stub out its graphics platforms in acceptance/integration tests by default

Robert Ancell (robert-ancell)
Changed in mir:
status: New → Triaged
Revision history for this message
Kevin DuBois (kdub) wrote :

What was happening was that (under android only) the test framework was being started with a stubbed graphics platform server side, but the client side was attempting to use the actual android drivers. When it went to apply the fake data from the server to the drivers, this generated a lot of errors.

The correction (in lp:~kdub/mir/fix-1220443 ) lets us put a stub client platform into our tests that run under our framework.

Why was this not seen previously?

The linking structure for these two tests was fragile. Prior to some CMakeList changes, this was not a problem because the mock android HAL was linked into the tests. Something in the link structure changed, and the linker started picking up the links to the actual drivers, causing problems. The solution should be more robust because it puts stubs in on the client side

Daniel van Vugt (vanvugt)
Changed in mir:
importance: Critical → High
Daniel van Vugt (vanvugt)
Changed in mir:
status: Triaged → In Progress
assignee: nobody → Kevin DuBois (kdub)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:~mir-team/mir/development-branch at revision 1093, scheduled for release in mir, milestone Unknown

Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → phone-v1-freeze
Daniel van Vugt (vanvugt)
tags: added: testsfail
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix released in:
mir (0.0.14+13.10.20131009.4-0ubuntu1) saucy; urgency=low

Changed in mir (Ubuntu):
status: New → Fix Released
importance: Undecided → High
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: phone-v1-freeze → 0.0.13
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.