VMware driver should not have a conditional on suds

Bug #1220344 reported by Dan Smith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Gary Kotton

Bug Description

The VMware driver has (at least one) block of code under an "if suds" conditional. This is not necessary since suds is a requirement for nova and therefore should be removed. The code that ignores the ImportError should be removed as well.

I'm marking this as low, because it doesn't prevent features from working, but would like to see it fixed before havana is released.

Tags: vmware
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/44926

Changed in nova:
assignee: Shawn Hartsock (hartsock) → Gary Kotton (garyk)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/44926
Committed: http://github.com/openstack/nova/commit/b15354bb557500653c8a3dc63bcb5e324955ec5f
Submitter: Jenkins
Branch: master

commit b15354bb557500653c8a3dc63bcb5e324955ec5f
Author: Gary Kotton <email address hidden>
Date: Tue Sep 3 11:05:28 2013 -0700

    VMware: remove conditional suds validation

    suds is now part of the requirements.txt file so we no longer
    need the conditional check.

    Fixes bug 1220344

    Change-Id: If2f63e3f997733146a9f93f43a6eaa76f77db530

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.