VMDK driver picks invalid datastore

[Kartik Bommepally]

VMwareVcVmdkDriver picks invalid datastore for e.g. inaccessible or readOnly for volume creation (create/clone) and the operation eventually fails.
The driver must ignore such datastores that are readOnly or which are not accessible or mounted to the ESX server.

Work around is to manually un-mount/re-mount the datastore on ESX that which are not accessible and to remove read-only datastores.
Fix is to have a filter for such datastores.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/44862

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/44862
Committed: http://github.com/openstack/cinder/commit/564f8d140fd8a968e55b1aee57200b9f015bee6d
Submitter: Jenkins
Branch: master

commit 564f8d140fd8a968e55b1aee57200b9f015bee6d
Author: Kartik Bommepally <email address hidden>
Date: Tue Sep 3 05:12:33 2013 -0700

    VMware driver: Fix for invalid datastore selection

    Added filter to ignore datastores that are not mounted, in-accessible
    and read-only for volume creation. Without this VMware's VC/ESX driver can
    choose such datastore with higher invalid capacity value as returned by the
    server for volume creation.

    Also using parent's self.mox object in the test cases rather than creating
    a new mox.Mox obj everytime.

    Fixes bug: 1220217

    Change-Id: If8319562ddc11fc31eb928b3807aead2b11b94bc