nova api should raise badrequest when create flavor with incorrect format of data in request body

Bug #1220087 reported by Yaguang Tang
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Yaguang Tang

Bug Description

nova api should raise HTTP 400 bad request when create flavor with incorrect format of data in request body, we should add a simple validation of the request data and avoid a 500 internal error .

Yaguang Tang (heut2008)
Changed in nova:
assignee: nobody → Yaguang Tang (heut2008)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/44807

Changed in nova:
status: New → In Progress
Andrew Laski (alaski)
Changed in nova:
importance: Undecided → Medium
milestone: none → havana-rc1
Changed in nova:
milestone: havana-rc1 → none
tags: added: havana-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/44807
Committed: http://github.com/openstack/nova/commit/d4e5b87d3f4f23d7c8f8f62e85aa5b75f77f7bd5
Submitter: Jenkins
Branch: master

commit d4e5b87d3f4f23d7c8f8f62e85aa5b75f77f7bd5
Author: Yaguang Tang <email address hidden>
Date: Tue Sep 3 15:48:36 2013 +0800

    Add flavor name validation when create flavor

    Check flavor name when create flavor, raise bad request instead
    of internal error when flavor name isn't present in request.

    Change flavor unit tests to make flavor create request body
    validation being tested.

    Closes-Bug: 1220087

    Co-authored-by: Takashi Natsume <email address hidden>
    Change-Id: I3ec1642305590aff61e54252405420082ac2f596

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.