Cannot clear binding:profile

Bug #1220011 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Akihiro Motoki

Bug Description

binding:profile attribute is a dict, but there is no way to clear it.
None is used to indicate to clear the corresponding attribute in general.
The validator for port binding should accept None.
It can be fixed by changing the type:dict to type:dict_or_none in the extension.

It is required by NEC plugin portbinding support ( https://blueprints.launchpad.net/neutron/+spec/nec-port-binding ) but it requires a change in the common code, so this bug will be fixed in a separate patch.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/44869

Changed in neutron:
status: New → In Progress
tags: added: neutron-core portbinding
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/44869
Committed: http://github.com/openstack/neutron/commit/d632b66dc8b701ca777af4335b6505b4c4cd7828
Submitter: Jenkins
Branch: master

commit d632b66dc8b701ca777af4335b6505b4c4cd7828
Author: Akihiro MOTOKI <email address hidden>
Date: Tue Sep 3 21:57:53 2013 +0900

    Allow None for binding:profile attribute

    We need to pass None in binding:profile to allow an administrator
    to clear binding:profile attribute.

    Closes-Bug: #1220011

    Adds dedicated unit tests to the plugins which uses binding:profile
    attribute (Mellanox and NEC plugins at now).

    This commit also adds common unit tests for binding:profile to
    the common PortBindingTestCase class.
    - create_port with binding:profile whose value is None or {}
    - update_port with binding:profile whose value is None or {}
    - Reject binding:profile from non-admin user

    Note that _make_port() in BigSwitch plugin test is updated
    to allow passing arg_list() from the base test class.

    Fix a bug in NEC plugin that 500 is returned when putting
    binding:profile None to a port whose binding:profile is
    already None (Closes-Bug: #1220720)

    Change-Id: I146afe961cd445a023adc7233588d8034fdb8437

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.