TimeLineBase cannot display more than one event for a given hour

[Olivier Tilloy]

The following is a (simplified) extract from TimeLineBase.qml:

    function createEventMap() {
        var eventMap = {};
        for(var i = 0 ; i < model.count ; ++i) {
            var event = model.get(i);
            eventMap[event.startTime.getHours()] = event
        }
        return eventMap;
    }

    function createEvents() {
        intern.eventMap = createEventMap();
        bubbleOverLay.destroyAllChildren();
        for( var i=0; i < 24; ++i ) {
            var event = intern.eventMap[i];
            if( event ) {
                bubbleOverLay.createEvent(event,i);
            }
        }
    }

When initially populating the event map, if two events have the same start hour, the second one overrides the first one, and so the first one is never displayed.

Using a map to represent the data is not suitable (or it should be a multi-map, associating lists of events to each hour).

[Olivier Tilloy (osomon)]

Bumping the importance to high as this makes one autopilot test flaky, because it relies on the presence of an event in the day view, which sometimes is not there due to this architectural issue:

    calendar_app.tests.test_calendar.TestMainView.test_new_event

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-calendar-app at revision 100, scheduled for release in ubuntu-calendar-app, milestone alpha-1