Outstanding issues to be resolved with cmake

Bug #1219569 reported by Cris Dywan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
High
Unassigned

Bug Description

x FAQ isn't being installed.
x Should say "gcr no" in about:version
x HAVE_GCR is not defined
x HAVE_OSX is not defined
x HAVE_GRANITE not in Vala flags
x no generated .png installed for .svg icons
x no debug flags
x C warnings disabled
x no doc generation
x no 'make check' but make test

Tags: cmake

Related branches

Cris Dywan (kalikiana)
tags: added: cmake
Cris Dywan (kalikiana)
description: updated
Cris Dywan (kalikiana)
description: updated
description: updated
Cris Dywan (kalikiana)
description: updated
Cris Dywan (kalikiana)
description: updated
Cris Dywan (kalikiana)
description: updated
Revision history for this message
Olivier Duchateau (duchateau-olivier) wrote :

I made patch for SVG image (logo-shade.svg), bug #1224692

New patch exists for execinfo.h header with BSD #1212761 (comment 3)

Revision history for this message
Olivier Duchateau (duchateau-olivier) wrote :

Add targets to build and install API documentation (gtk-doc), bug #1225693

Donte Greene (flykidd)
Changed in midori:
status: Confirmed → In Progress
Revision history for this message
Olivier Duchateau (duchateau-olivier) wrote :

Add install target, in order to install .mo files bug #1228159

Revision history for this message
Olivier Duchateau (duchateau-olivier) wrote :

Add CMakeLists.txt for config/ directory, bug #1228359

Cris Dywan (kalikiana)
description: updated
Revision history for this message
Kevin Fenzi (kevin-launchpad) wrote :

The header and vapi files don't seem to get installed with cmake, where they do with waf:

/usr/include/midori-0.5
/usr/include/midori-0.5/extensions
/usr/include/midori-0.5/extensions/apps.h
/usr/include/midori-0.5/extensions/delayed-load.h
/usr/include/midori-0.5/extensions/devpet.h
/usr/include/midori-0.5/extensions/external-download-manager.h
/usr/include/midori-0.5/extensions/history-list.h
/usr/include/midori-0.5/extensions/nsplugin-manager.h
/usr/include/midori-0.5/extensions/transfers.h
/usr/share/vala/vapi/apps.deps
/usr/share/vala/vapi/apps.vapi
/usr/share/vala/vapi/delayed-load.deps
/usr/share/vala/vapi/delayed-load.vapi
/usr/share/vala/vapi/devpet.deps
/usr/share/vala/vapi/devpet.vapi
/usr/share/vala/vapi/external-download-manager.deps
/usr/share/vala/vapi/external-download-manager.vapi
/usr/share/vala/vapi/history-list.deps
/usr/share/vala/vapi/history-list.vapi
/usr/share/vala/vapi/nsplugin-manager.deps
/usr/share/vala/vapi/nsplugin-manager.vapi
/usr/share/vala/vapi/transfers.deps
/usr/share/vala/vapi/transfers.vapi

Otherwise with the mo/mgo fix, things build ok here. ;)

Revision history for this message
Cris Dywan (kalikiana) wrote :

Those headers were actually a long-standing bug in the waf build, it makes no sense at all to install them (we should install midori-*.h some day and probably will as part of the libpeas work).

Cris Dywan (kalikiana)
Changed in midori:
status: In Progress → Fix Committed
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.