attempting to delete a non existant flavor extra spec returns 204

[Christopher Yeoh]

Attempting to delete a non existant flavor extra spec returns 204 instead of 404

[Jake Liu (jake-liu)]

Hi Chris, there are two ways to fix this:

1) Directly change 204 to 404 in
@wsgi.response(404)
def delete(self, req, flavor_id, id):

2) Use

@wsgi.response(204)
@extensions.expected_errors(404)
def delete(self, req, flavor_id, id):

Solution 2) also needs to update DB api to make sure instance_type_extra_specs_delete throw excetion so as to let delete() catch the exception and throw HTTPNotFound.

Which one do you think is better? Thanks.

[Christopher Yeoh (cyeoh-0)]

Not sure about what you mean by the first, but the the second is the way I was thinking it should be fixed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/44771

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/44771
Committed: http://github.com/openstack/nova/commit/be2018c9ddcfb830ca8a3b9b4ab0dbc60d6bb732
Submitter: Jenkins
Branch: master

commit be2018c9ddcfb830ca8a3b9b4ab0dbc60d6bb732
Author: Jake Liu <email address hidden>
Date: Mon Sep 2 18:18:17 2013 -0400

    delete a non existent flavor extra spec returns 204

    Attempting to delete a non existent flavor extra spec returns
    204 instead of 404, the fix was return 404 for such case.

    Fix bug 1219445

    Change-Id: I61db53486b5696fe74f16ac2d98971092137fadf