LUKS not capitalized properly

Bug #1219085 reported by David Lyle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Romain Hardouin

Bug Description

On the quotas tab in the admin/system info panel (soon to be on the admin Defaults panel) quotas concerning LUKS print Luks.

Floren (florenllanos)
Changed in horizon:
status: New → Confirmed
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Low
Changed in horizon:
assignee: nobody → Romain Hardouin (romain-hardouin)
Changed in horizon:
milestone: none → havana-rc1
tags: added: havana-rc-potential
Changed in horizon:
milestone: havana-rc1 → icehouse-1
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Which fields should be fixed?
I checked "Default Quotas" tab in "Defaults" panel, but I am not sure which should be fixed.

Revision history for this message
David Lyle (david-lyle) wrote :

The fields are:
 "Snapshots Luks"
 "Gigabytes Luks"
 "Volumes Luks"

Luks => LUKS

I was leaving this a low hanging fruit.

Revision history for this message
David Lyle (david-lyle) wrote :

While we're at it, looks like
 "Fixed Ips" => "Fixed IPs"
 "Ram" => "RAM"
 "Dm-Crypt" => "dm-crypt"

Revision history for this message
Romain Hardouin (romain-hardouin) wrote :

I see three fields to fix, is it correct?

Volumes Volume Luks
Snapshots Volume Luks
Gigabytes Volume Luks

Revision history for this message
Romain Hardouin (romain-hardouin) wrote :

Sorry David, I haven't saw your comments at the time I wrote mine.
OK so I'll special case LUKS and dm-crypt in QUOTA_NAMES (admin/defaults/tables.py).
I saw that RAM and Fixed IPs are already fixed.
Thank you.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/49459

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Romain Hardouin (romain-hardouin) wrote :

Kieran Spear suggests to make LUKS quota names easier to understand.
I quote him:

What does "Volumes Volume LUKS" mean though? Can we make this easier to understand?
E.g., "LUKS Volumes", "LUKS Volumes Gigabytes", "LUKS Volume Snapshots"
Or maybe "LUKS Volumes Size (GB)" for the middle one?

I think it's a good idea.
What do you think about this?

Revision history for this message
David Lyle (david-lyle) wrote :

I think your samples sound reasonable to me. I agree that the original text was confusing at best.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/49459
Committed: http://github.com/openstack/horizon/commit/5b6a96a050b63d6f91eb56211a6052871e91c209
Submitter: Jenkins
Branch: master

commit 5b6a96a050b63d6f91eb56211a6052871e91c209
Author: Romain Hardouin <email address hidden>
Date: Thu Oct 3 03:02:27 2013 +0200

    LUKS quotas names easier to understand

    Change-Id: I977d77d4360589bf335f7b036703e155088e0122
    Closes-Bug: #1219085

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
tags: added: havana-backport-potential
removed: havana-rc-potential
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.