volume up/down key is not working anymore with the new indicator-sound

Bug #1219057 reported by Ricardo Salveti
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
unity8 (Ubuntu)
Fix Released
High
Unassigned
Saucy
Won't Fix
High
Unassigned

Bug Description

Since the new indicator-sound (real one) was integrated, the volume up/down key doesn't work anymore in unity8.

Looking at the QML file (Components/VolumeControl.qml), that's because the old dbus interface is not available anymore.

So looking for the proper implementation now, we just need to understand if it'd need to be ported to the new indicator or talking with pulseaudio directly.

Tags: avengers

Related branches

Revision history for this message
David Henningsson (diwic) wrote :

<diwic> tvoss, kgunn anyway, my quick question was "does it make any sense for me to write a volume key up/down reader in PulseAudio directly" and the answer is no,
<diwic> because you want it to be kernel -> mir -> sound indicator -> pulseaudio instead
<diwic> right?
<tvoss> diwic, yup

Lars Karlitski (larsu)
Changed in unity8 (Ubuntu):
status: New → In Progress
assignee: nobody → Lars Uebernickel (larsu)
Michael Hall (mhall119)
tags: added: avengers
Changed in touch-preview-images:
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 7.81.3+13.10.20130919.3-0ubuntu1

---------------
unity8 (7.81.3+13.10.20130919.3-0ubuntu1) saucy; urgency=low

  [ Michal Hruby ]
  * Add support for music grid renderer to GenericScopeView.

  [ Nick Dedekind ]
  * Fixed the removal of messaging widget due to incompatible action
    state. (LP: #1225017)

  [ Christopher Lee ]
  * Addition of initial autopilot tests for the application lifecycle.

  [ Lars Uebernickel ]
  * VolumeControl: use action of the new indicator indicator-sound
    recently gained an action to increase and decrease the volume. This
    patch makes use of that to get rid of a bus round trip (to get the
    current volume) and a race (when the volume gets set between
    fetching the current volume and setting the new volume). (LP:
    #1219057)

  [ Michael Terry ]
  * When AccountsService.backgroundFile is unset/invalid, have the
    greeter fall back to whatever the shell background is.
  * Add a tiny SessionBroadcast plugin that listens to unity-greeter-
    session-broadcast for the ShowHome signal.

  [ Daniel d'Andrada ]
  * Remove obsolete, unused graphics.
  * Make MouseTouchAdaptor work with multiple QWindows.

  [ Michael Zanetti ]
  * change how icons are searched a) try to find it the Icon as is b)
    prepend with Path if a Path variable is given c) fall back to the
    image://theme/ with just the icon name . (LP: #1225186)
  * fix an issue with removing a running app from the launcher and
    always store pinning to the config.
  * collapse any open preview when programmatically switching current
    dash index. (LP: #1221137)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 333
 -- Ubuntu daily release <email address hidden> Thu, 19 Sep 2013 15:15:07 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Bill Filler (bfiller) wrote :

This is not fixed.
per ricmm:
what it means is that the shell needs to mediate the volume keys. the shell already listens to keys in a few places in Shell.qml, regardless of Mir, the interface is independent. Mir or SF routing of events happens at a lower layer. key events are delivered to the shell, the shell decides what to do in our case it is talk out to pulseaudio via some API
<ricmm> I guess dbus, or is it a native C api?
<diwic> ricmm, native C api. indicator-sound already uses it to set the volume
<diwic> ricmm, kernel -> mir -> indicator-sound -> pulseaudio
<diwic> ricmm, that's what I've been told.
<diwic> ricmm, feel free to revise
<ricmm> unity8 is Mir, and it receives key events directly
<ricmm> it just needs to route to the correct pulseaudio interface
<ricmm> Mir doesnt do any special event processing and direct dispatch (internally to mir) to pulseaudio, it just delivers to the shell (unity8)
<diwic> ricmm, it should route the events to the sound indicator?
<ricmm> yes
<diwic> ricmm, and the sound indicator already talks to pulseaudio the right way AFAIK
<ricmm> well then its just a matter of catching the KEY_EVENT in Shell.qml as it is done now for the power button
<ricmm> theres example code there
<ricmm> and signalling the indicator
<diwic> ricmm, okay, if you say so?
<ricmm> I do

Changed in unity8 (Ubuntu):
status: Fix Released → Confirmed
importance: Undecided → High
assignee: Lars Uebernickel (larsu) → nobody
Revision history for this message
Michał Sawicz (saviq) wrote :

Why do you say Bill that's not the case? It's exactly what happens under SF now (on Mir this is broken by bug #1233245).

There's a bigger issue here where we want to allow *apps* to get the volume up/down events to override the default system behavior (like change the call volume when on a call, change video / music volume when playing music, otherwise change incoming call sound / profile). IMO we should learn from MeeGo here -it's really intuitive there.

Bill Filler (bfiller)
no longer affects: touch-preview-images
kevin gunn (kgunn72)
Changed in unity8 (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

saucy has seen the end of its life and is no longer receiving any updates. Marking the saucy task for this ticket as "Won't Fix".

Changed in unity8 (Ubuntu Saucy):
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.