Switch to higher compression of GUI source
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-gui |
Fix Released
|
High
|
Gary Poster |
Bug Description
With this diff to the GUI...
=== modified file 'Makefile'
--- Makefile 2013-08-16 20:16:31 +0000
+++ Makefile 2013-08-30 12:29:50 +0000
@@ -95,7 +95,7 @@
LAUNCHPAD_
endif
RELEASE_
-RELEASE_
+RELEASE_
RELEASE_
NPM_CACHE_
NPM_CACHE_
...we get a release that is 30% smaller than the current version.
ls -l releases/
total 63788
-rw-r--r-- 1 gary gary 38348212 Aug 30 08:29 juju-gui-
-rw-r--r-- 1 gary gary 26965680 Aug 30 08:31 juju-gui-
With this diff to the charm...
=== modified file 'hooks/utils.py'
--- hooks/utils.py 2013-08-26 15:53:22 +0000
+++ hooks/utils.py 2013-08-30 12:40:15 +0000
@@ -677,7 +677,7 @@
release_dir = os.path.
cmd_
os.
- uncompress = command('tar', '-x', '-z', '-C', release_dir, '-f')
+ uncompress = command('tar', '-x', '-a', '-C', release_dir, '-f')
cmd_
# Link the Juju GUI dir to the contents of the release tarball.
cmd_
...the charm should be able to transparently handle tgz or xz release (diff is untested).
Seems like an easy win to me, yeah?
This can be done in addition to/separately from making the tarball leaner in terms of what we include.
This xz change could also be applied to our npm cache stuff, but that affects fewer people.
Doing this might be nice to support bug 1218871.
Related branches
- charmers: Pending requested
-
Diff: 209 lines (+82/-37)2 files modifiedhooks/utils.py (+7/-3)
tests/test_utils.py (+75/-34)
- Juju GUI Hackers: Pending requested
-
Diff: 12 lines (+1/-1)1 file modifiedMakefile (+1/-1)
Changed in juju-gui: | |
assignee: | nobody → Gary Poster (gary) |
status: | Triaged → In Progress |
importance: | Low → High |
Changed in juju-gui: | |
status: | In Progress → Fix Committed |
Changed in juju-gui: | |
status: | Fix Committed → Fix Released |