OpenStack DBaaS (Trove)

additional, random properties are not allowed in validation

Bug #1218661 reported by Michael Basnight on 2013-08-29

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack DBaaS (Trove)	Fix Released	Critical	Nikhil Manchanda	OpenStack DBaaS (Trove) 2013.2 "havana"

Bug Description

Adding goofy properties to json requests cause validation failures. This is not the way the API worked before the jsonschema validation was implemented. We should test allowAdditionalProperties on the jsonschema documents to see if it allows us to have the same api as before + validation.

Michael Basnight (hubcap) on 2013-08-29

Changed in trove:
status:	New → Confirmed
importance:	Undecided → Critical
milestone:	none → havana-3

Michael Basnight (hubcap) on 2013-08-29

Changed in trove:
milestone:	havana-3 → havana-rc1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-08-30: Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/44510

Changed in trove:
assignee:	nobody → Ed Cranford (ed--cranford)
status:	Confirmed → In Progress

OpenStack Infra (hudson-openstack) on 2013-09-09

Changed in trove:
assignee:	Ed Cranford (ed--cranford) → Nikhil Manchanda (slicknik)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-09: Fix merged to trove (master)

Reviewed: https://review.openstack.org/44510
Committed: http://github.com/openstack/trove/commit/2afe9ee1644ffb4e922fa5e329142866997c1fff
Submitter: Jenkins
Branch: master

commit 2afe9ee1644ffb4e922fa5e329142866997c1fff
Author: Ed Cranford <email address hidden>
Date: Fri Aug 30 13:17:17 2013 -0500

Made apischema a bit less restrictive.

    All additionalProperties are now True instead of False
    All array minsizes are now 0 instead of 1
    Create Instance now has an additional service_type optional property

    fixes bug #1215183
    fixes bug #1218661
    fixes bug #1218662

Change-Id: If5c9344464a730220a588294383bb473e7bc5e7c