Fix unsuitable assertTrue/assertFalse in api unittest

Bug #1218621 reported by ZhiQiang Fan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
ZhiQiang Fan

Bug Description

Some usages of assertTrue()/assertFalse() are incorrect, improve them to more explicit assert from the unit test suite (like assertIsNotNone or assertIn).

ZhiQiang Fan (aji-zqfan)
Changed in neutron:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
ZhiQiang Fan (aji-zqfan)
summary: - Fix unsuitable assertTrue() in api unittest
+ Fix unsuitable assertTrue/assertFalse in api unittest
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/44366

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/44366
Committed: http://github.com/openstack/neutron/commit/3ba80960075bf7873e96914f1be54ae176069a8d
Submitter: Jenkins
Branch: master

commit 3ba80960075bf7873e96914f1be54ae176069a8d
Author: ZhiQiang Fan <email address hidden>
Date: Fri Aug 30 05:35:32 2013 +0800

    Fix unsuitable assertTrue/assertFalse in api ut

    Some usages of assertTrue()/assertFalse() are incorrect, improve
    them to more explicit assert from the unit test suite.

    Closes-Bug: #1218621
    Change-Id: I22be2af05f06e91020dbaa4cf08bf395d68f563b

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
importance: Undecided → Low
Changed in neutron:
milestone: none → havana-3
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.