purchase order merge limits

[martin]

Not a bug, but suggestion for improvement.

I have added a few fields to purchase.order using my own module in v 7.0.

When I try to use do_merge on the purchase orders I created, the custom fields are not written to the new purchase order.

Unfortunately, the function do_merge does all in one and returns when everything is finished.
It would be nice to split up the function into several functions, one of which is responsible to set the values of the dictionary to compare / merge.
Another function should define which fields should be compared to decide whether to merge or not. And so on.
That would simplify the possibility to customize.

And having read https://bugs.launchpad.net/openobject-addons/+bug/1091268, I would suggest to do something similar with porder.notes.

[Amit Parik (amit-parik)]

Hello Martin,

Could not understand your bug report properly, Would you please provide the more information on this like which kind of output you got and what is your expected behavior etc.

Thank you and waiting for your reply!

[martin (riess82)]

changed the report.

[Leonardo Donelli (learts92)]

I found myself in the same situation. As of now, the only way to make the system consider the custom fields in the merged purchase order is to redefine the whole `do_merge` function (almost 100 lines) in my addon, even if I only need to change a single line and the other 99 will be a simple copy and paste.

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

We should probably add a community addon redefining this behaviour for extensibility and use it as dependency for other addons wanting to customize the PO merging criteria.

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

And I also suggest we try to get OpenERP SA accept a merge toward better overridability in v8. It's extremely hard to get them merge community improvements, but if community focus on a few hot spots only that cannot really be brought be extensions nor fixed within a release because they would break the API, may be it's possible. In v7 we managed to get them merge these _prepare_* methods in after I insisted so much they were essential for extensibility.