Odoo Addons (MOVED TO GITHUB)

[7.0] Generate recurring move is not company aware

Bug #1217779 reported by Nicolas Bessi - Camptocamp on 2013-08-28

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Committed	Medium	OpenERP Publisher's Warranty Team

Bug Description

The wizard that generate recurring move ignore company and breaks on security rules in multi company mode.

Inside transient model "account.subscription.generate" function action_generate, there is a direct use of the cursor that ignore the user current company:
cr.execute('select id from account_subscription_line where date<%s and move_id is null', (data['date'],))

So it tries to generate lines for all companies and breaks on security rules

Regards

Nicolas

Tags:

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-1217779-mba

Ready for review for merging into lp:openobject-addons

Nicolas Bessi - Camptocamp (community): Disapprove on 2014-01-08

Alexandre Fayolle - camptocamp (community): Needs Information (code review, no test) on 2014-01-08

OpenERP Core Team: Pending requested 2014-01-08

Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) on 2013-08-28

summary:

- Generate recurring move is not company aware
+ [7.0] Generate recurring move is not company aware

Amit Parik (amit-parik) on 2013-08-30

Changed in openobject-addons:
assignee:	nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance:	Undecided → Medium
status:	New → Confirmed

Amit Parik (amit-parik) on 2013-10-21

tags:

added: invoicing

Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) on 2013-10-21

tags:

added: multi-company

Revision history for this message

Mahendra Barad(OpenERP) (mba-openerp) wrote on 2014-01-08:

Hello,

It has been fixed into https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1217779-mba
branch with following

Revision ID: <email address hidden>
Revision No:9038

Thanks.

Changed in openobject-addons:
status:	Confirmed → In Progress
status:	In Progress → Fix Committed

Revision history for this message

Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote on 2014-01-08:

hello,

Current SQL is faulty and gives following error

ERROR: more than one row returned by a subquery used as an expression.

If we look to the query these error seems logical.

I have not investigate more, it is maybe due to corrupted setup and we should never have such configuration but I dont think so.

Alexandre query works out of the box.

Regards

Nicolas

Vinay Rana (OpenERP) (vra-openerp) on 2014-05-13

Changed in openobject-addons:
assignee:	OpenERP R&D Addons Team 3 (openerp-dev-addons3) → OpenERP Publisher's Warranty Team (openerp-opw)
tags:	added: maintenance