Pagination support for Glance and Keystone ignores user-set params

Bug #1217608 reported by Nicolas Simonds
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Nicolas Simonds

Bug Description

I noticed that the Glance and Keystone APIs for openstack_dashboard added pagination support. This is good.

But they only use the admin-provided value, and not the one in the user cookie. That's bad.

The Nova API works as expected. Make the others do the same thing.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43963

Changed in horizon:
assignee: nobody → Nicolas Simonds (nicolas.simonds)
status: New → In Progress
Revision history for this message
Nicolas Simonds (nicolas.simonds) wrote :

It's also amusing, because the Keystone guys have told me in no uncertain terms that pagination support was never implemented, so the API ignores it.

Revision history for this message
David Lyle (david-lyle) wrote :

The keystone v2 API supports pagination, it's just v3 that does not. So support was added for v2 type pagination. v3 style pagination will be different and requires wider changes in horizon, noteably the table class. There is a blueprint for v3 pagination support once in.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/43963
Committed: http://github.com/openstack/horizon/commit/4b70efafb480f882e86e0def9da8e8e7dc0146cb
Submitter: Jenkins
Branch: master

commit 4b70efafb480f882e86e0def9da8e8e7dc0146cb
Author: Nicolas Simonds <email address hidden>
Date: Thu Aug 29 10:17:34 2013 -0700

    Use the horizon_pagesize value in the session cookie

    This makes the API calls that are claiming to do pagination work
    the same as Nova, which has had it the longest. Namely, there's a
    user setting to control how many rows get returned. Make them heed
    it.

    Fixes Bug: 1217608
    Change-Id: I19b4d7c77d595b898abb81462f6343bbc1b93eb6

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.