vmwareapi drivers - most summary fields need not be set

[Shawn Hartsock]

In host.py method update_status,

Several status fields may not be set by the vSphere endpoint.

    summary.hardware <- all children will be None
    summary.config
    summary.quickStats.overallMemoryUsage

Write code to handle these missing attributes gracefully.

References:
* http://pubs.vmware.com/vsphere-51/index.jsp#com.vmware.wssdk.apiref.doc/vim.host.Summary.html#field_detail
* http://pubs.vmware.com/vsphere-51/index.jsp#com.vmware.wssdk.apiref.doc/vim.host.Summary.QuickStats.html

[Shawn Hartsock (hartsock)]

I'm calling this critical, because when it does happen (doesn't always) there will be no work around.

[Russell Bryant (russellb)]

I think it's better as High, since it doesn't affect *all* users.

"High if the bug prevents a key feature from working properly for some users (or with a workaround)"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/44006

[Gary Kotton (garyk)]

The problem happens if the nova compute service is restarted. This at times has a situation where is is impossible to restart the nova compute service. We should consider changing this to critical. Please see the trace below when I restarted the compute service:

2013-09-02 00:59:40.979 INFO nova.compute.manager [req-10927006-b0e9-4159-9032-6337bbad97e5 None None] Updating host status
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/eventlet/hubs/poll.py", line 97, in wait
    readers.get(fileno, noop).cb(fileno)
  File "/usr/local/lib/python2.7/dist-packages/eventlet/greenthread.py", line 194, in main
    result = function(*args, **kwargs)
  File "/opt/stack/nova/nova/openstack/common/service.py", line 65, in run_service
    service.start()
  File "/opt/stack/nova/nova/service.py", line 154, in start
    self.manager.init_host()
  File "/opt/stack/nova/nova/compute/manager.py", line 757, in init_host
    self._report_driver_status(context)
  File "/opt/stack/nova/nova/compute/manager.py", line 4409, in _report_driver_status
    capabilities = self.driver.get_host_stats(refresh=True)
  File "/opt/stack/nova/nova/virt/vmwareapi/driver.py", line 363, in get_host_stats
    return self.host_state.get_host_stats(refresh=refresh)
  File "/opt/stack/nova/nova/virt/vmwareapi/driver.py", line 434, in host_state
    self._cluster)
  File "/opt/stack/nova/nova/virt/vmwareapi/host.py", line 155, in __init__
    self.update_status()
  File "/opt/stack/nova/nova/virt/vmwareapi/host.py", line 201, in update_status
    summary.quickStats.overallMemoryUsage
AttributeError: 'Text' object has no attribute 'overallMemoryUsage'
Removing descriptor: 7
2013-09-02 00:59:41.382 ERROR nova.openstack.common.threadgroup [-] 'Text' object has no attribute 'overallMemoryUsage'
2013-09-02 00:59:41.382 TRACE nova.openstack.common.threadgroup Traceback (most recent call last):
2013-09-02 00:59:41.382 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/openstack/common/threadgroup.py", line 117, in wait
2013-09-02 00:59:41.382 TRACE nova.openstack.common.threadgroup x.wait()
2013-09-02 00:59:41.382 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/openstack/common/threadgroup.py", line 49, in wait
2013-09-02 00:59:41.382 TRACE nova.openstack.common.threadgroup return self.thread.wait()
2013-09-02 00:59:41.382 TRACE nova.openstack.common.threadgroup File "/usr/local/lib/python2.7/dist-packages/eventlet/greenthread.py", line 168, in wait
2013-09-02 00:59:41.382 TRACE nova.openstack.common.threadgroup return self._exit_event.wait()
2013-09-02 00:59:41.382 TRACE nova.openstack.common.threadgroup File "/usr/local/lib/python2.7/dist-packages/eventlet/event.py", line 116, in wait
2013-09-02 00:59:41.382 TRACE nova.openstack.common.threadgroup return hubs.get_hub().switch()
2013-09-02 00:59:41.382 TRACE nova.openstack.common.threadgroup File "/usr/local/lib/python2.7/dist-packages/eventlet/hubs/hub.py", line 187, in switch
2013-09-02 00:59:41.382 TRACE nova.openstack.common.threadgroup return self.greenlet.switch()
2013-09-02 00:59:41.382 TRACE nova.openstack.common.threadgroup File "/usr...

[dan wendlandt (danwent)]

Gary, it sounds like russell's argument is that 'critical' should be reserved for bugs that apply to all users, regardless of what virt driver is used. This is not the case for this bug.

If that is the metric, it seems reasonable for this to be high.

[Russell Bryant (russellb)]

current patch for this: https://review.openstack.org/#/c/43621/

[Davanum Srinivas (DIMS) (dims-v)]

https://review.openstack.org/#/c/43621/

[Gary Kotton (garyk)]

This was addressed in https://bugs.launchpad.net/nova/+bug/1190515