abs_queue does not properly use move semantics
Bug #1217388 reported by
Rick Stovall
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| New Real Time Battle | Status tracked in Alpha | |||||
| Alpha |
Fix Released
|
Critical
|
Rick Stovall | |||
Bug Description
nrtb::abs_queue does not implement move semantics (std::move()) when pushing and popping items from the queue. This prevents the use of std::unique_ptr<> and therefore, the ability to enforce unique resource ownership where appropriate.
Related branches
lp:~fpstovall/nrtb/fps-sprint-003
- Rick Stovall: Approve
-
Diff: 1216 lines (+914/-67)23 files modifiedMakefile (+1/-2)
cpp/Makefile (+31/-0)
cpp/common/Makefile (+1/-0)
cpp/common/abs_queue/abs_queue.h (+3/-3)
cpp/common/circular_queue/circular_queue.h (+1/-1)
cpp/common/ipc_channel/Makefile (+47/-0)
cpp/common/ipc_channel/ipc_channel.cpp (+44/-0)
cpp/common/ipc_channel/ipc_channel.h (+75/-0)
cpp/common/ipc_channel/ipc_channel_test.cpp (+133/-0)
cpp/common/sockets/base_socket.cpp (+9/-5)
cpp/common/sockets/base_socket.h (+6/-7)
cpp/sim_engine/Makefile (+3/-4)
cpp/sim_engine/control_interface/Makefile (+47/-0)
cpp/sim_engine/control_interface/control_interface.cpp (+27/-0)
cpp/sim_engine/control_interface/control_interface.h (+50/-0)
cpp/sim_engine/control_interface/control_interface_test.cpp (+60/-0)
cpp/sim_engine/main/Makefile (+40/-0)
cpp/sim_engine/main/simengine.cpp (+81/-0)
cpp/sim_engine/messages/Makefile (+47/-0)
cpp/sim_engine/messages/messages.cpp (+62/-0)
cpp/sim_engine/messages/messages.h (+61/-0)
cpp/sim_engine/messages/messages_test.cpp (+85/-0)
cpp/sim_engine/physics/Makefile (+0/-45)
| summary: |
- abs_queue does not properly use move emantics + abs_queue does not properly use move semantics |
Revision history for this message
| Rick Stovall (fpstovall) wrote | #1 |
| Changed in nrtb: | |
| status: | New → Fix Committed |
Revision history for this message
| Rick Stovall (fpstovall) wrote | #2 |
To post a comment you must log in.
Fix actually required small changes to both abs_queue and circular_queue.