sample config file has syntax error (but commented out)

Bug #1217135 reported by Jay Buffington
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
ZhiQiang Fan

Bug Description

    # Add python stack traces to SQL as comment strings
    # connection_trace = False,

If you uncomment the connection_trace line without removing the trailing comma you get this error:
    2013-08-26 23:26:22.490 30871 CRITICAL neutron [-] Unexpected boolean value 'False,'

ZhiQiang Fan (aji-zqfan)
Changed in neutron:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Revision history for this message
ZhiQiang Fan (aji-zqfan) wrote :

this is introduced in ee3fe4e836ca1c81e50a8324a9b5f982de4fa97f

also find:
rpc_thread_pool_size = 64,
max_overflow = 20,

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43805

Changed in neutron:
importance: Undecided → Medium
milestone: none → havana-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/43805
Committed: http://github.com/openstack/neutron/commit/fbd55e7dbd1c4ca2a1fc33b1ec5f54a484bda691
Submitter: Jenkins
Branch: master

commit fbd55e7dbd1c4ca2a1fc33b1ec5f54a484bda691
Author: ZhiQiang Fan <email address hidden>
Date: Tue Aug 27 08:17:55 2013 +0800

    Remove trailing comma

    Closes-Bug: #1217135

    There are trailing commas in default value of some options, uncomment
    them will cause CRITICAL error for neutron-server. These sample config
    may mislead operators, so this patch fix them to the correct format.

    Change-Id: Ie0b7626aade653b761257eb2bf397cb3cc5a961e

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.