query_to_kwargs inconsistent behaviour on invalid input
Bug #1217129 reported by
gordon chung
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ceilometer |
Fix Released
|
Undecided
|
gordon chung |
Bug Description
relating patch to add testcases for _query_to_kwargs() function, invalid operators and fields will give different results
if you have an invalid field but valid operator ('eq'), an UnknownArgument is raised
if you have an invalid operator but valid field, a warning is logged but query continues to be processed
if you have invalid field and invalid operator, invalid operator takes precedence, warning logged, and query continues.
i don't think invalid operator should hide the invalid field error. we should probably be raising for invalid operator and invalid field.
thoughts?
Changed in ceilometer: | |
assignee: | gordon chung (chungg) → Tong Li (litong01) |
Changed in ceilometer: | |
assignee: | Tong Li (litong01) → gordon chung (chungg) |
Changed in ceilometer: | |
status: | In Progress → Fix Committed |
Changed in ceilometer: | |
milestone: | none → havana-rc1 |
status: | Fix Committed → Fix Released |
Changed in ceilometer: | |
milestone: | havana-rc1 → 2013.2 |
To post a comment you must log in.
Fix proposed to branch: master /review. openstack. org/43796
Review: https:/