Upgrading to 2.4.1-1 version causes meld to crash.

Bug #12170 reported by Debian Bug Importer
4
Affects Status Importance Assigned to Milestone
libglade2 (Debian)
Fix Released
Unknown
libglade2 (Ubuntu)
Invalid
High
Sebastien Bacher

Bug Description

Automatically imported from Debian bug report #290811 http://bugs.debian.org/290811

Revision history for this message
In , Steve Langasek (vorlon) wrote : Re; meld crashes on start

Hi Bas,

I can't reproduce this problem on a current sid or sarge system. Do you
have any GTK-related packages installed from experimental?

--
Steve Langasek
postmodern programmer

Revision history for this message
In , Bas Zoetekouw (baszoetekouw) wrote : Re: Bug#290811: Re; meld crashes on start

Hi Steve!

You wrote:

> I can't reproduce this problem on a current sid or sarge system. Do you
> have any GTK-related packages installed from experimental?

As far as I now, this is an up-to-date sid system. Also, I can
reproduce it on two different machines, so I don't think it's some local
error.

Note though that the crash only occurs when diffing two directories, not
when simple diffing two files.

--
Kind regards,
+--------------------------------------------------------------------+
| Bas Zoetekouw | GPG key: 0644fab7 |
|----------------------------| Fingerprint: c1f5 f24c d514 3fec 8bf6 |
| <email address hidden>, <email address hidden> | a2b1 2bae e41f 0644 fab7 |
+--------------------------------------------------------------------+

Revision history for this message
In , Margarita Manterola (marga) wrote : I can't reproduce it either
Download full text (4.5 KiB)

I've been trying to reproduce this bug as well, with no luck. I have the
same versions of meld and its dependencies as the ones listed in the bug
report.

However, I also have the complete GNOME environment, and because of what's
stated in the rest of this mail I'm inclined to think that Bas doesn't and
that the core of the problem is there: meld is failing to declare some
extra dependencies on some GNOME packages, that any GNOME user will have
installed by default (or something of the sort).

> [bas@matilda]/scratch/kevin> meld test/mn_fit_v5_03 mn-fit-5.03
> /usr/lib/meld/gnomeglade.py:145: GtkWarning: Unable to locate theme engine in module_path: "raleigh",
> image = gtk.Image()

This seems to be a problem related to the lack of the package
"gtk-engines-pixmap" that contains the file
"/usr/lib/gtk/themes/engines/libraleigh.la"

Maybe meld should declare a "Suggests" or "Recommends" on this package, but
I think this part is can be safely declared unrelated to the crashing bug.

> /usr/lib/meld/gnomeglade.py:46: GtkWarning: file gtklabel.c: line 2792 (gtk_label_set_use_underline): assertion `GTK_IS_LABEL (label)' failed
> self.xml = gtk.glade.XML(file, root, gettext.textdomain() )
> /usr/lib/meld/gnomeglade.py:46: GtkWarning: gtkwidget.c:3076: widget `GtkToolButton' has no activatable signal "clicked" without arguments
> self.xml = gtk.glade.XML(file, root, gettext.textdomain() )

> (meld:1619): GLib-GObject-WARNING **: gsignal.c:1657: signal `pressed' is invalid for instance `0x8393338'

I don't get any of these. All of these warnings seem to be related to GTK
issues. Maybe I don't get them because I have a different libgtk2.0-0
version (2.4.14-2).

> /usr/lib/meld/dirdiff.py:278: DeprecationWarning:
> _("Hide %s") % f.label, "", icon, self._update_name_filter, i )

I do get this one, but it's just a warning.

> /usr/lib/meld/dirdiff.py:278: GtkWarning: mixing deprecated and non-deprecated GtkToolbar API is not allowed
> _("Hide %s") % f.label, "", icon, self._update_name_filter, i )

I don't get this, and I think it might be symptomatic of what's going on.

> Traceback (most recent call last):
> File "/usr/bin/meld", line 88, in ?
> meldapp.main()
> File "/usr/lib/meld/meldapp.py", line 911, in main
> app.append_diff(args)
> File "/usr/lib/meld/meldapp.py", line 798, in append_diff
> self.append_dirdiff(paths)
> File "/usr/lib/meld/meldapp.py", line 770, in append_dirdiff
> doc = dirdiff.DirDiff(self.prefs, len(dirs))
> File "/usr/lib/meld/dirdiff.py", line 242, in __init__
> self.create_name_filters()
> File "/usr/lib/meld/dirdiff.py", line 279, in create_name_filters
> toggle.set_active(f.active)
> AttributeError: 'NoneType' object has no attribute 'set_active'

Even if I can't reproduce the bug, from the traceback, we can have a look
at the code and guess where the bug is:

        for i,f in misc.enumerate(self.name_filters_available):
            icon = gtk.Image()
            icon.set_from_stock(gtk.STOCK_FIND, gtk.ICON_SIZE_LARGE_TOOLBAR)
            icon.show()
            toggle = self.toolbar.append_element(gtk.TOOLBAR_CHILD_TOGGLEBUTTON, None, f.label,
                _("Hide ...

Read more...

Revision history for this message
In , Bas Zoetekouw (baszoetekouw) wrote : Re: Bug#290811: I can't reproduce it either
Download full text (3.6 KiB)

Hi Margarita!

You wrote:

> However, I also have the complete GNOME environment, and because of what's
> stated in the rest of this mail I'm inclined to think that Bas doesn't and
> that the core of the problem is there: meld is failing to declare some
> extra dependencies on some GNOME packages, that any GNOME user will have
> installed by default (or something of the sort).

Could be (as I did have gnome 2.8 installed frome xperimental in the
past, and something might have gone wrng with upgrades or something),
but otoh, I have this same problem on two computers.

> > [bas@matilda]/scratch/kevin> meld test/mn_fit_v5_03 mn-fit-5.03
> > /usr/lib/meld/gnomeglade.py:145: GtkWarning: Unable to locate theme engine in module_path: "raleigh",
> > image = gtk.Image()
>
> This seems to be a problem related to the lack of the package
> "gtk-engines-pixmap" that contains the file
> "/usr/lib/gtk/themes/engines/libraleigh.la"

Yes, I get this with all gtk apps. It's due to my gtk theme I think. I
do have gtk-engines-pixmap installed though.

> Maybe meld should declare a "Suggests" or "Recommends" on this package, but
> I think this part is can be safely declared unrelated to the crashing bug.
>
> > /usr/lib/meld/gnomeglade.py:46: GtkWarning: file gtklabel.c: line 2792 (gtk_label_set_use_underline): assertion `GTK_IS_LABEL (label)' failed
> > self.xml = gtk.glade.XML(file, root, gettext.textdomain() )
> > /usr/lib/meld/gnomeglade.py:46: GtkWarning: gtkwidget.c:3076: widget `GtkToolButton' has no activatable signal "clicked" without arguments
> > self.xml = gtk.glade.XML(file, root, gettext.textdomain() )
>
> > (meld:1619): GLib-GObject-WARNING **: gsignal.c:1657: signal `pressed' is invalid for instance `0x8393338'
>
> I don't get any of these. All of these warnings seem to be related to GTK
> issues. Maybe I don't get them because I have a different libgtk2.0-0
> version (2.4.14-2).

I have that same version of libgtk-2.0-0:

[bas@iasoon]/tmp> dpkg -l libgtk2.0-0 | grep ^ii
ii libgtk2.0-0 2.4.14-2 The GTK+ graphical user interface library

> > /usr/lib/meld/dirdiff.py:278: DeprecationWarning:
> > _("Hide %s") % f.label, "", icon, self._update_name_filter, i )
>
> I do get this one, but it's just a warning.

ok.

> Reading the helpfile in devhelp, it says "gtk_toolbar_append_element is
> deprecated and should not be used in newly-written code.", so, the
> deprecated part of the code is the call to the function itself.
>
> I really fail to see which is the non-deprecated part of the function
> called (I've been reading the gtktoolbar.c source code, with no luck). But
> yet, since gtktoolbar is part of libgtk, I think it might be a versioning
> problem.

I wouldn't be surprised, especially since meld work fine until a few
weeks ago, while its version hasn't changed since august.

> The dependency tree is:
> meld depends on python-gtk2, which depends on python2.3-gtk2 which depends
> on " libgtk2.0-0 (>= 2.4.4) ". libgtk2.0-0 is presently at 2.4.14, I'm
> guessing that Bas might have a version that is in the middle of the two,
> and that for some reason has this "non-deprecated vs deprecated" issue.

Nopes, this is an up...

Read more...

Revision history for this message
In , Steve Langasek (vorlon) wrote : mrph

forwarded 290811 http://bugzilla.gnome.org/show_bug.cgi?id=163322';
merge 290811 287166
thanks

Revision history for this message
In , Margarita Manterola (marga) wrote : Re: Bug#290811: I can reproduce it now

Reassign 290811 libglade2-0
Retitle 290811 Upgrading to 2.4.1-1 version causes meld to crash.
thanks

Hola Bas Zoetekouw!

> > The dependency tree is:
> > meld depends on python-gtk2, which depends on python2.3-gtk2 which depends
> > on " libgtk2.0-0 (>= 2.4.4) ". libgtk2.0-0 is presently at 2.4.14, I'm
> > guessing that Bas might have a version that is in the middle of the two,
> > and that for some reason has this "non-deprecated vs deprecated" issue.
> Nopes, this is an up-to-date sid system, with the latest gnome and gtk
> libraries.

Ok, based on this information, I kept investigating and found out that
after upgrading libglade2-0 to version 2.4.1-1, I can reproduce the bug,
though with the previous version (2.4.0-1) it did not occur.

Thus, I'm reassigning this bug to libglade. I'll keep working on this,
hoping to find a solution.

--
 Bezos, (o.
     Marga. (/)_

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Automatically imported from Debian bug report #290811 http://bugs.debian.org/290811

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <email address hidden>
Date: Sun, 16 Jan 2005 22:47:05 +0100
From: Bas Zoetekouw <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: meld crashes on start

Package: meld
Version: 0.9.4.1-1
Severity: grave

Since a while back, meld simply stopped working:

[bas@matilda]/scratch/kevin> meld test/mn_fit_v5_03 mn-fit-5.03
/usr/lib/meld/gnomeglade.py:145: GtkWarning: Unable to locate theme engine in module_path: "raleigh",
  image = gtk.Image()
/usr/lib/meld/gnomeglade.py:46: GtkWarning: file gtklabel.c: line 2792 (gtk_label_set_use_underline): assertion `GTK_IS_LABEL (label)' failed
  self.xml = gtk.glade.XML(file, root, gettext.textdomain() )
/usr/lib/meld/gnomeglade.py:46: GtkWarning: gtkwidget.c:3076: widget `GtkToolButton' has no activatable signal "clicked" without arguments
  self.xml = gtk.glade.XML(file, root, gettext.textdomain() )

(meld:1619): GLib-GObject-WARNING **: gsignal.c:1657: signal `pressed' is invalid for instance `0x8393338'
/usr/lib/meld/dirdiff.py:278: DeprecationWarning:
  _("Hide %s") % f.label, "", icon, self._update_name_filter, i )
/usr/lib/meld/dirdiff.py:278: GtkWarning: mixing deprecated and non-deprecated GtkToolbar API is not allowed
  _("Hide %s") % f.label, "", icon, self._update_name_filter, i )
Traceback (most recent call last):
  File "/usr/bin/meld", line 88, in ?
    meldapp.main()
  File "/usr/lib/meld/meldapp.py", line 911, in main
    app.append_diff(args)
  File "/usr/lib/meld/meldapp.py", line 798, in append_diff
    self.append_dirdiff(paths)
  File "/usr/lib/meld/meldapp.py", line 770, in append_dirdiff
    doc = dirdiff.DirDiff(self.prefs, len(dirs))
  File "/usr/lib/meld/dirdiff.py", line 242, in __init__
    self.create_name_filters()
  File "/usr/lib/meld/dirdiff.py", line 279, in create_name_filters
    toggle.set_active(f.active)
AttributeError: 'NoneType' object has no attribute 'set_active'

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.9-ac6
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)

Versions of packages meld depends on:
ii python 2.3.4-5 An interactive high-level object-o
ii python-glade2 2.4.1-2 GTK+ bindings: Glade support
ii python-gnome2 2.6.1-1 Python bindings for the GNOME desk
ii python-gtk2 2.4.1-2 Python bindings for the GTK+ widge

-- no debconf information

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Sat, 22 Jan 2005 06:17:58 -0800
From: Steve Langasek <email address hidden>
To: <email address hidden>, <email address hidden>
Subject: Re; meld crashes on start

--rz+pwK2yUstbofK6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Bas,

I can't reproduce this problem on a current sid or sarge system. Do you
have any GTK-related packages installed from experimental?

--=20
Steve Langasek
postmodern programmer

--rz+pwK2yUstbofK6
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFB8mCTKN6ufymYLloRAnDnAJ9y7W1cTyIfD4TI/cW3XmMub24VtgCgxfc0
h3Iw/c3IZzGBMjTzZNKALdk=
=wrQ5
-----END PGP SIGNATURE-----

--rz+pwK2yUstbofK6--

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Sat, 22 Jan 2005 18:08:51 +0100
From: Bas Zoetekouw <email address hidden>
To: Steve Langasek <email address hidden>, <email address hidden>
Subject: Re: Bug#290811: Re; meld crashes on start

Hi Steve!

You wrote:

> I can't reproduce this problem on a current sid or sarge system. Do you
> have any GTK-related packages installed from experimental?

As far as I now, this is an up-to-date sid system. Also, I can
reproduce it on two different machines, so I don't think it's some local
error.

Note though that the crash only occurs when diffing two directories, not
when simple diffing two files.

--
Kind regards,
+--------------------------------------------------------------------+
| Bas Zoetekouw | GPG key: 0644fab7 |
|----------------------------| Fingerprint: c1f5 f24c d514 3fec 8bf6 |
| <email address hidden>, <email address hidden> | a2b1 2bae e41f 0644 fab7 |
+--------------------------------------------------------------------+

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (4.7 KiB)

Message-ID: <20050123012135.GA27378@localhost>
Date: Sat, 22 Jan 2005 22:21:35 -0300
From: Margarita Manterola <email address hidden>
To: <email address hidden>, <email address hidden>
Subject: I can't reproduce it either

I've been trying to reproduce this bug as well, with no luck. I have the
same versions of meld and its dependencies as the ones listed in the bug
report.

However, I also have the complete GNOME environment, and because of what's
stated in the rest of this mail I'm inclined to think that Bas doesn't and
that the core of the problem is there: meld is failing to declare some
extra dependencies on some GNOME packages, that any GNOME user will have
installed by default (or something of the sort).

> [bas@matilda]/scratch/kevin> meld test/mn_fit_v5_03 mn-fit-5.03
> /usr/lib/meld/gnomeglade.py:145: GtkWarning: Unable to locate theme engine in module_path: "raleigh",
> image = gtk.Image()

This seems to be a problem related to the lack of the package
"gtk-engines-pixmap" that contains the file
"/usr/lib/gtk/themes/engines/libraleigh.la"

Maybe meld should declare a "Suggests" or "Recommends" on this package, but
I think this part is can be safely declared unrelated to the crashing bug.

> /usr/lib/meld/gnomeglade.py:46: GtkWarning: file gtklabel.c: line 2792 (gtk_label_set_use_underline): assertion `GTK_IS_LABEL (label)' failed
> self.xml = gtk.glade.XML(file, root, gettext.textdomain() )
> /usr/lib/meld/gnomeglade.py:46: GtkWarning: gtkwidget.c:3076: widget `GtkToolButton' has no activatable signal "clicked" without arguments
> self.xml = gtk.glade.XML(file, root, gettext.textdomain() )

> (meld:1619): GLib-GObject-WARNING **: gsignal.c:1657: signal `pressed' is invalid for instance `0x8393338'

I don't get any of these. All of these warnings seem to be related to GTK
issues. Maybe I don't get them because I have a different libgtk2.0-0
version (2.4.14-2).

> /usr/lib/meld/dirdiff.py:278: DeprecationWarning:
> _("Hide %s") % f.label, "", icon, self._update_name_filter, i )

I do get this one, but it's just a warning.

> /usr/lib/meld/dirdiff.py:278: GtkWarning: mixing deprecated and non-deprecated GtkToolbar API is not allowed
> _("Hide %s") % f.label, "", icon, self._update_name_filter, i )

I don't get this, and I think it might be symptomatic of what's going on.

> Traceback (most recent call last):
> File "/usr/bin/meld", line 88, in ?
> meldapp.main()
> File "/usr/lib/meld/meldapp.py", line 911, in main
> app.append_diff(args)
> File "/usr/lib/meld/meldapp.py", line 798, in append_diff
> self.append_dirdiff(paths)
> File "/usr/lib/meld/meldapp.py", line 770, in append_dirdiff
> doc = dirdiff.DirDiff(self.prefs, len(dirs))
> File "/usr/lib/meld/dirdiff.py", line 242, in __init__
> self.create_name_filters()
> File "/usr/lib/meld/dirdiff.py", line 279, in create_name_filters
> toggle.set_active(f.active)
> AttributeError: 'NoneType' object has no attribute 'set_active'

Even if I can't reproduce the bug, from the traceback, we can have a look
at the code and guess where the bug is:

        for i,f in misc.enumerate(self.name_filters_available):
            icon = g...

Read more...

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (3.8 KiB)

Message-ID: <email address hidden>
Date: Sun, 23 Jan 2005 04:08:31 +0100
From: Bas Zoetekouw <email address hidden>
To: Margarita Manterola <email address hidden>
Cc: <email address hidden>
Subject: Re: Bug#290811: I can't reproduce it either

Hi Margarita!

You wrote:

> However, I also have the complete GNOME environment, and because of what's
> stated in the rest of this mail I'm inclined to think that Bas doesn't and
> that the core of the problem is there: meld is failing to declare some
> extra dependencies on some GNOME packages, that any GNOME user will have
> installed by default (or something of the sort).

Could be (as I did have gnome 2.8 installed frome xperimental in the
past, and something might have gone wrng with upgrades or something),
but otoh, I have this same problem on two computers.

> > [bas@matilda]/scratch/kevin> meld test/mn_fit_v5_03 mn-fit-5.03
> > /usr/lib/meld/gnomeglade.py:145: GtkWarning: Unable to locate theme engine in module_path: "raleigh",
> > image = gtk.Image()
>
> This seems to be a problem related to the lack of the package
> "gtk-engines-pixmap" that contains the file
> "/usr/lib/gtk/themes/engines/libraleigh.la"

Yes, I get this with all gtk apps. It's due to my gtk theme I think. I
do have gtk-engines-pixmap installed though.

> Maybe meld should declare a "Suggests" or "Recommends" on this package, but
> I think this part is can be safely declared unrelated to the crashing bug.
>
> > /usr/lib/meld/gnomeglade.py:46: GtkWarning: file gtklabel.c: line 2792 (gtk_label_set_use_underline): assertion `GTK_IS_LABEL (label)' failed
> > self.xml = gtk.glade.XML(file, root, gettext.textdomain() )
> > /usr/lib/meld/gnomeglade.py:46: GtkWarning: gtkwidget.c:3076: widget `GtkToolButton' has no activatable signal "clicked" without arguments
> > self.xml = gtk.glade.XML(file, root, gettext.textdomain() )
>
> > (meld:1619): GLib-GObject-WARNING **: gsignal.c:1657: signal `pressed' is invalid for instance `0x8393338'
>
> I don't get any of these. All of these warnings seem to be related to GTK
> issues. Maybe I don't get them because I have a different libgtk2.0-0
> version (2.4.14-2).

I have that same version of libgtk-2.0-0:

[bas@iasoon]/tmp> dpkg -l libgtk2.0-0 | grep ^ii
ii libgtk2.0-0 2.4.14-2 The GTK+ graphical user interface library

> > /usr/lib/meld/dirdiff.py:278: DeprecationWarning:
> > _("Hide %s") % f.label, "", icon, self._update_name_filter, i )
>
> I do get this one, but it's just a warning.

ok.

> Reading the helpfile in devhelp, it says "gtk_toolbar_append_element is
> deprecated and should not be used in newly-written code.", so, the
> deprecated part of the code is the call to the function itself.
>
> I really fail to see which is the non-deprecated part of the function
> called (I've been reading the gtktoolbar.c source code, with no luck). But
> yet, since gtktoolbar is part of libgtk, I think it might be a versioning
> problem.

I wouldn't be surprised, especially since meld work fine until a few
weeks ago, while its version hasn't changed since august.

> The dependency tree is:
> meld depends on python-gtk2, which depends on python2.3-gtk2 w...

Read more...

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Sun, 23 Jan 2005 01:21:20 -0800
From: Steve Langasek <email address hidden>
To: <email address hidden>
Subject: mrph

forwarded 290811 http://bugzilla.gnome.org/show_bug.cgi?id=163322';
merge 290811 287166
thanks

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <20050123135858.GA9219@localhost>
Date: Sun, 23 Jan 2005 10:58:58 -0300
From: Margarita Manterola <email address hidden>
To: Bas Zoetekouw <email address hidden>, <email address hidden>
Cc: <email address hidden>
Subject: Re: Bug#290811: I can reproduce it now

Reassign 290811 libglade2-0
Retitle 290811 Upgrading to 2.4.1-1 version causes meld to crash.
thanks

Hola Bas Zoetekouw!

> > The dependency tree is:
> > meld depends on python-gtk2, which depends on python2.3-gtk2 which depends
> > on " libgtk2.0-0 (>= 2.4.4) ". libgtk2.0-0 is presently at 2.4.14, I'm
> > guessing that Bas might have a version that is in the middle of the two,
> > and that for some reason has this "non-deprecated vs deprecated" issue.
> Nopes, this is an up-to-date sid system, with the latest gnome and gtk
> libraries.

Ok, based on this information, I kept investigating and found out that
after upgrading libglade2-0 to version 2.4.1-1, I can reproduce the bug,
though with the previous version (2.4.0-1) it did not occur.

Thus, I'm reassigning this bug to libglade. I'll keep working on this,
hoping to find a solution.

--
 Bezos, (o.
     Marga. (/)_

Revision history for this message
In , Margarita Manterola (marga) wrote : Patch that fixes the problem in libglade

Merge 288445 287167 290811
Tags 290811 +patch
thanks

I'm attaching a patch that fixes these bugs.

They were all the same bug: libglade2 made an important update in the code
of glade-gtk.c that started using the new toolbar api. This change
rendered programs that used both glade and the toolbar api directly
unusable.

Upstream report: http://bugzilla.gnome.org/show_bug.cgi?id=163322

The patch I'm attaching was made with interdiff. It is indended to make the
less damage possible. I only regressed those changes that affected the way
meld and synaptic behaved (I don't know if there are other programs
affected by this bug).

With these changes, the two programs behave properly, almost no warnings
issued on the console. I hope you find this patch worthy of applying.

--
 Bezitos,
     Maggie.

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (5.4 KiB)

Message-ID: <20050123153159.GA28849@localhost>
Date: Sun, 23 Jan 2005 12:31:59 -0300
From: Margarita Manterola <email address hidden>
To: <email address hidden>, <email address hidden>, <email address hidden>
Cc: <email address hidden>
Subject: Patch that fixes the problem in libglade

--QTprm0S8XgL7H0Dt
Content-Type: multipart/mixed; boundary="azLHFNyN32YCQGCU"
Content-Disposition: inline

--azLHFNyN32YCQGCU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Merge 288445 287167 290811
Tags 290811 +patch
thanks

I'm attaching a patch that fixes these bugs.

They were all the same bug: libglade2 made an important update in the code
of glade-gtk.c that started using the new toolbar api. This change
rendered programs that used both glade and the toolbar api directly
unusable.

Upstream report: http://bugzilla.gnome.org/show_bug.cgi?id=3D163322

The patch I'm attaching was made with interdiff. It is indended to make the
less damage possible. I only regressed those changes that affected the way
meld and synaptic behaved (I don't know if there are other programs
affected by this bug).

With these changes, the two programs behave properly, almost no warnings
issued on the console. I hope you find this patch worthy of applying.

--=20
 Bezitos,
     Maggie.

--azLHFNyN32YCQGCU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="libglade-patch.interdiff"
Content-Transfer-Encoding: quoted-printable

diff -u libglade2-2.4.1/debian/changelog libglade2-2.4.1/debian/changelog
--- libglade2-2.4.1/debian/changelog
+++ libglade2-2.4.1/debian/changelog
@@ -1,3 +1,9 @@
+libglade2 (1:2.4.1-1.1) unstable; urgency=3Dlow
+
+ * Undo the update of the API, so that synaptic and meld keep working.
+
+ -- Margarita Manterola <email address hidden> Sun, 23 Jan 2005 11:49:01 -=
0300
+
 libglade2 (1:2.4.1-1) unstable; urgency=3Dlow
=20
   * GNOME team upload.
only in patch2:
unchanged:
--- libglade2-2.4.1.orig/glade/glade-gtk.c
+++ libglade2-2.4.1/glade/glade-gtk.c
@@ -868,71 +868,46 @@
      if (iconw)
   gtk_widget_show (iconw);
=20
- if (new_group) {
- GtkWidget *toolitem =3D GTK_WIDGET (gtk_tool_item_new ());
-
- gtk_container_add (GTK_CONTAINER (parent), toolitem);
- gtk_widget_show (toolitem);
- }
+ if (new_group)
+ gtk_toolbar_append_space (GTK_TOOLBAR (parent));
=20
      /* FIXME: these should be translated */
      if (!strcmp (childinfo->child->classname, "toggle")) {
- child =3D g_object_new (GTK_TYPE_TOGGLE_TOOL_BUTTON,
- "label", label,
- "stock_id", stock,
- NULL);
- gtk_toggle_tool_button_set_active
- (GTK_TOGGLE_TOOL_BUTTON (child), active);
+ child =3D gtk_toolbar_append_element (
+ GTK_TOOLBAR (parent),
+ GTK_TOOLBAR_CHILD_TOGGLEBUTTON, NULL,
+ label, tooltip, NULL, iconw, NULL, NULL);
+ gtk_toggle_button_set_active(
+ GTK_TOGGLE_BUTTON (child), active);
      } else if (!strcmp (childinfo->child->classname, "radio")) {
- child =3D g_object_new (GTK_TYPE_RADIO_TOOL_BUTTON,
- "label", label,
- "stock_id", stock,
- NULL);
+ child =3D gtk_toolbar_append_ele...

Read more...

Revision history for this message
In , Ross Burton (ross) wrote : Re: Bug#287167: Patch that fixes the problem in libglade

On Sun, 2005-01-23 at 12:31 -0300, Margarita Manterola wrote:
> They were all the same bug: libglade2 made an important update in the code
> of glade-gtk.c that started using the new toolbar api. This change
> rendered programs that used both glade and the toolbar api directly
> unusable.

What about glade files and applications which expect the new API to be
used? The problem is that the two APIs cannot be mixed, so will this
change just result in a different set of applications breaking?

I hope to be proved wrong... :)

Ross
--
Ross Burton mail: <email address hidden>
                                          jabber: <email address hidden>
                                     www: http://www.burtonini.com./
 PGP Fingerprint: 1A21 F5B0 D8D0 CFE3 81D4 E25A 2D09 E447 D0B4 33DF

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <1106501473.26917.5.camel@localhost>
Date: Sun, 23 Jan 2005 17:31:13 +0000
From: Ross Burton <email address hidden>
To: Margarita Manterola <email address hidden>, <email address hidden>
Cc: <email address hidden>, <email address hidden>
Subject: Re: Bug#287167: Patch that fixes the problem in libglade

On Sun, 2005-01-23 at 12:31 -0300, Margarita Manterola wrote:
> They were all the same bug: libglade2 made an important update in the code
> of glade-gtk.c that started using the new toolbar api. This change
> rendered programs that used both glade and the toolbar api directly
> unusable.

What about glade files and applications which expect the new API to be
used? The problem is that the two APIs cannot be mixed, so will this
change just result in a different set of applications breaking?

I hope to be proved wrong... :)

Ross
--
Ross Burton mail: <email address hidden>
                                          jabber: <email address hidden>
                                     www: http://www.burtonini.com./
 PGP Fingerprint: 1A21 F5B0 D8D0 CFE3 81D4 E25A 2D09 E447 D0B4 33DF

Revision history for this message
In , Margarita Manterola (marga) wrote :

Hola Ross Burton!

> What about glade files and applications which expect the new API to be
> used? The problem is that the two APIs cannot be mixed, so will this
> change just result in a different set of applications breaking?

If there are applications that use the new api directly, yes, they will be
broken. The fact is that we are really close to the famous sarge freeze,
and if other applications break because of this, they probably won't be
allowed to enter sarge. After Sarge is released we can go and ask all the
applications to update their API (I guess).

--
 Besos,
     Maggie.

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <20050123182127.GA29154@localhost>
Date: Sun, 23 Jan 2005 15:21:28 -0300
From: Margarita Manterola <email address hidden>
To: Ross Burton <email address hidden>
Cc: <email address hidden>, <email address hidden>, <email address hidden>
Subject: Re: Bug#287167: Patch that fixes the problem in libglade

Hola Ross Burton!

> What about glade files and applications which expect the new API to be
> used? The problem is that the two APIs cannot be mixed, so will this
> change just result in a different set of applications breaking?

If there are applications that use the new api directly, yes, they will be
broken. The fact is that we are really close to the famous sarge freeze,
and if other applications break because of this, they probably won't be
allowed to enter sarge. After Sarge is released we can go and ask all the
applications to update their API (I guess).

--
 Besos,
     Maggie.

Revision history for this message
In , Andreas Rottmann (rotty) wrote : libglade2 toolbar problems should be fixed in applications

Margarita Manterola <email address hidden> wrote:

> Hola Ross Burton!
>
>> What about glade files and applications which expect the new API to be
>> used? The problem is that the two APIs cannot be mixed, so will this
>> change just result in a different set of applications breaking?
>
> If there are applications that use the new api directly, yes, they will be
> broken. The fact is that we are really close to the famous sarge freeze,
> and if other applications break because of this, they probably won't be
> allowed to enter sarge. After Sarge is released we can go and ask all the
> applications to update their API (I guess).
>
I think meld should be fixed to work with the new libglade, instead of
the other way around (quoting from [0]):

[0] http://bugzilla.gnome.org/show_bug.cgi?id=160586

,----
| libglade-2.4.1 is building toolbars using the new GtkToolbar API.
| Meld is then adding some buttons to the toolbar with the old API
| (append_element). If you use the new toolbar APIs, things should
| work fine.
|
| You might need to open/save your project in a new version of glade
| to upgrade the toolbars to use GtkToolButtons.
`----

It is no viable strategy to release with a libglade2 that has
incompatible behaviour to upstream. Just think of a user compiling
software locally that relies on the changes made in libglade
2.4.1. Also, it seems synaptic, which also had this issue (see
#288642) has already been fixed, as has the Linux kernel's gconfig
system.

So, I've you cannot convince me that libglade2 should be patched (I
think you won't be able to :-P), I'll reassign #290811 this to meld.

Regards, Rotty
--
Andreas Rottmann | Rotty@ICQ | 118634484@ICQ | <email address hidden>
http://yi.org/rotty | GnuPG Key: http://yi.org/rotty/gpg.asc
Fingerprint | DFB4 4EB4 78A4 5EEE 6219 F228 F92F CFC5 01FD 5B62

Say NO to Software Patents! -- http://petition.eurolinux.org/

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Tue, 25 Jan 2005 11:29:27 +0100
From: Andreas Rottmann <email address hidden>
To: Ross Burton <email address hidden>, Margarita Manterola
 <email address hidden>, Alex Roitman <email address hidden>, baiju m <email address hidden>
Cc: <email address hidden>, <email address hidden>
Subject: libglade2 toolbar problems should be fixed in applications

Margarita Manterola <email address hidden> wrote:

> Hola Ross Burton!
>
>> What about glade files and applications which expect the new API to be
>> used? The problem is that the two APIs cannot be mixed, so will this
>> change just result in a different set of applications breaking?
>
> If there are applications that use the new api directly, yes, they will be
> broken. The fact is that we are really close to the famous sarge freeze,
> and if other applications break because of this, they probably won't be
> allowed to enter sarge. After Sarge is released we can go and ask all the
> applications to update their API (I guess).
>
I think meld should be fixed to work with the new libglade, instead of
the other way around (quoting from [0]):

[0] http://bugzilla.gnome.org/show_bug.cgi?id=160586

,----
| libglade-2.4.1 is building toolbars using the new GtkToolbar API.
| Meld is then adding some buttons to the toolbar with the old API
| (append_element). If you use the new toolbar APIs, things should
| work fine.
|
| You might need to open/save your project in a new version of glade
| to upgrade the toolbars to use GtkToolButtons.
`----

It is no viable strategy to release with a libglade2 that has
incompatible behaviour to upstream. Just think of a user compiling
software locally that relies on the changes made in libglade
2.4.1. Also, it seems synaptic, which also had this issue (see
#288642) has already been fixed, as has the Linux kernel's gconfig
system.

So, I've you cannot convince me that libglade2 should be patched (I
think you won't be able to :-P), I'll reassign #290811 this to meld.

Regards, Rotty
--
Andreas Rottmann | Rotty@ICQ | 118634484@ICQ | <email address hidden>
http://yi.org/rotty | GnuPG Key: http://yi.org/rotty/gpg.asc
Fingerprint | DFB4 4EB4 78A4 5EEE 6219 F228 F92F CFC5 01FD 5B62

Say NO to Software Patents! -- http://petition.eurolinux.org/

Revision history for this message
In , Steve Langasek (vorlon) wrote :

> It is no viable strategy to release with a libglade2 that has
> incompatible behaviour to upstream. Just think of a user compiling
> software locally that relies on the changes made in libglade
> 2.4.1.

Then you will need to change the name of the libglade binary package
instead. It is not acceptable to make changes in a library package that
will silently break partial upgrades from woody in this fashion. Either the
ABI must be reverted to provide backwards compatibility, or the package name
must be changed and all packages currently depending on libglade2-0 will
have to be rebuilt.

In the meantime, the changes to libglade2-0 should be reverted *anyway*, so
that we have something that's releasable without having to wait for as many
as 174 binary packages to be rebuilt against the new interface.

Being incompatible with upstream should always be a secondary concern next
to being incompatible with our own previous releases.

> Also, it seems synaptic, which also had this issue (see
> #288642) has already been fixed, as has the Linux kernel's gconfig
> system.

The version of synaptic that fixed this bug is not a candidate for sarge,
per the maintainer.

--
Steve Langasek
postmodern programmer

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Tue, 25 Jan 2005 06:52:08 -0800
From: Steve Langasek <email address hidden>
To: <email address hidden>
Subject: Re: libglade2 toolbar problems should be fixed in applications

--Kj7319i9nmIyA2yE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> It is no viable strategy to release with a libglade2 that has
> incompatible behaviour to upstream. Just think of a user compiling
> software locally that relies on the changes made in libglade
> 2.4.1.

Then you will need to change the name of the libglade binary package
instead. It is not acceptable to make changes in a library package that
will silently break partial upgrades from woody in this fashion. Either the
ABI must be reverted to provide backwards compatibility, or the package name
must be changed and all packages currently depending on libglade2-0 will
have to be rebuilt.

In the meantime, the changes to libglade2-0 should be reverted *anyway*, so
that we have something that's releasable without having to wait for as many
as 174 binary packages to be rebuilt against the new interface.

Being incompatible with upstream should always be a secondary concern next
to being incompatible with our own previous releases.

> Also, it seems synaptic, which also had this issue (see
> #288642) has already been fixed, as has the Linux kernel's gconfig
> system.

The version of synaptic that fixed this bug is not a candidate for sarge,
per the maintainer.

--=20
Steve Langasek
postmodern programmer

--Kj7319i9nmIyA2yE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFB9l0UKN6ufymYLloRAqh4AJoDWChDfFcWhCB48LmXUvKOUS4kIQCff804
y1wBrBg7bcP+EoKZWOFFAW8=
=dlle
-----END PGP SIGNATURE-----

--Kj7319i9nmIyA2yE--

Revision history for this message
In , Andreas Rottmann (rotty) wrote : Correct forwarded adress
Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <email address hidden>
Date: Sat, 29 Jan 2005 19:53:40 +0100
From: Andreas Rottmann <email address hidden>
To: <email address hidden>
Subject: Correct forwarded adress

forwarded 290811 http://bugzilla.gnome.org/show_bug.cgi?id=163322
thanks

Revision history for this message
In , Andreas Rottmann (rotty) wrote : This has been fixed by the version of meld in sid

tags 290811 + sarge
thanks

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <email address hidden>
Date: Tue, 08 Feb 2005 22:59:25 +0100
From: Andreas Rottmann <email address hidden>
To: <email address hidden>
Subject: This has been fixed by the version of meld in sid

tags 290811 + sarge
thanks

Revision history for this message
In , Steve Langasek (vorlon) wrote :

Hi Andreas,

I see that you've tagged this bug "sarge", but I don't understand why? The
same version of libglade2-0 appears to be in sid as well.

--
Steve Langasek
postmodern programmer

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Tue, 8 Feb 2005 20:00:56 -0800
From: Steve Langasek <email address hidden>
To: <email address hidden>
Subject: Re: Upgrading to 2.4.1-1 version causes meld to crash.

--RIYY1s2vRbPFwWeW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Andreas,

I see that you've tagged this bug "sarge", but I don't understand why? The
same version of libglade2-0 appears to be in sid as well.

--=20
Steve Langasek
postmodern programmer

--RIYY1s2vRbPFwWeW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFCCYr1KN6ufymYLloRAtxIAKCf4iq5HiuIv6b/pvqiahJwb5IicACgliUZ
ZK55WfR4M/mcStxPv8lmzRk=
=3pvY
-----END PGP SIGNATURE-----

--RIYY1s2vRbPFwWeW--

Revision history for this message
In , Andreas Rottmann (rotty) wrote : Re: Bug#290811: Upgrading to 2.4.1-1 version causes meld to crash.

Steve Langasek <email address hidden> writes:

> Hi Andreas,
>
> I see that you've tagged this bug "sarge", but I don't understand why? The
> same version of libglade2-0 appears to be in sid as well.
>
Well, the applications (meld, synaptic, AFAIK) that broke with 2.4.1
have been fixed in sid.

Regards, Rotty

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Wed, 09 Feb 2005 11:17:50 +0100
From: Andreas Rottmann <email address hidden>
To: Steve Langasek <email address hidden>
Cc: <email address hidden>
Subject: Re: Bug#290811: Upgrading to 2.4.1-1 version causes meld to crash.

Steve Langasek <email address hidden> writes:

> Hi Andreas,
>
> I see that you've tagged this bug "sarge", but I don't understand why? The
> same version of libglade2-0 appears to be in sid as well.
>
Well, the applications (meld, synaptic, AFAIK) that broke with 2.4.1
have been fixed in sid.

Regards, Rotty

Revision history for this message
In , Jordi Mallach (jordi) wrote : Bug#290811: fixed in libglade2 1:2.4.2-1

Source: libglade2
Source-Version: 1:2.4.2-1

We believe that the bug you reported is fixed in the latest version of
libglade2, which is due to be installed in the Debian FTP archive:

libglade2-0_2.4.2-1_i386.deb
  to pool/main/libg/libglade2/libglade2-0_2.4.2-1_i386.deb
libglade2-dev_2.4.2-1_i386.deb
  to pool/main/libg/libglade2/libglade2-dev_2.4.2-1_i386.deb
libglade2_2.4.2-1.diff.gz
  to pool/main/libg/libglade2/libglade2_2.4.2-1.diff.gz
libglade2_2.4.2-1.dsc
  to pool/main/libg/libglade2/libglade2_2.4.2-1.dsc
libglade2_2.4.2.orig.tar.gz
  to pool/main/libg/libglade2/libglade2_2.4.2.orig.tar.gz

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jordi Mallach <email address hidden> (supplier of updated libglade2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 11 Feb 2005 14:09:34 +0100
Source: libglade2
Binary: libglade2-0 libglade2-dev
Architecture: source i386
Version: 1:2.4.2-1
Distribution: unstable
Urgency: medium
Maintainer: Jordi Mallach <email address hidden>
Changed-By: Jordi Mallach <email address hidden>
Description:
 libglade2-0 - library to load .glade files at runtime
 libglade2-dev - development files for libglade
Closes: 290811
Changes:
 libglade2 (1:2.4.2-1) unstable; urgency=medium
 .
   * New upstream release.
     - reverts the handling of old toolbars to the pre-2.4.1 behaviour,
       with the exception of the "active" handling for radio buttons.
       This should not break new packages that use the new toolbar API
       (closes: #290811).
   * debian/patches/01_filechooser: removed, fixed upstream.
Files:
 a1254df2e6a24506cec84b6a610b552a 1558 devel optional libglade2_2.4.2-1.dsc
 c1d1ff86fc9bb7d73fa9d71f8db01c9d 406345 devel optional libglade2_2.4.2.orig.tar.gz
 a53fc84df422798be5078c02b7282429 25986 devel optional libglade2_2.4.2-1.diff.gz
 470d3d6760db6abc42f12de75b9b2a08 82430 libs optional libglade2-0_2.4.2-1_i386.deb
 bdddf63cb9f4be22c0cf7a8dffe1ee1e 124210 libdevel optional libglade2-dev_2.4.2-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCDLONJYSUupF6Il4RAmDlAJ9Alpn7IdoPpVlAQ7ofcu06UdJKjwCeMVA2
aSzNXiUGjaDaVimGez7EKn4=
=QFWk
-----END PGP SIGNATURE-----

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <email address hidden>
Date: Fri, 11 Feb 2005 08:47:14 -0500
From: Jordi Mallach <email address hidden>
To: <email address hidden>
Subject: Bug#290811: fixed in libglade2 1:2.4.2-1

Source: libglade2
Source-Version: 1:2.4.2-1

We believe that the bug you reported is fixed in the latest version of
libglade2, which is due to be installed in the Debian FTP archive:

libglade2-0_2.4.2-1_i386.deb
  to pool/main/libg/libglade2/libglade2-0_2.4.2-1_i386.deb
libglade2-dev_2.4.2-1_i386.deb
  to pool/main/libg/libglade2/libglade2-dev_2.4.2-1_i386.deb
libglade2_2.4.2-1.diff.gz
  to pool/main/libg/libglade2/libglade2_2.4.2-1.diff.gz
libglade2_2.4.2-1.dsc
  to pool/main/libg/libglade2/libglade2_2.4.2-1.dsc
libglade2_2.4.2.orig.tar.gz
  to pool/main/libg/libglade2/libglade2_2.4.2.orig.tar.gz

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jordi Mallach <email address hidden> (supplier of updated libglade2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 11 Feb 2005 14:09:34 +0100
Source: libglade2
Binary: libglade2-0 libglade2-dev
Architecture: source i386
Version: 1:2.4.2-1
Distribution: unstable
Urgency: medium
Maintainer: Jordi Mallach <email address hidden>
Changed-By: Jordi Mallach <email address hidden>
Description:
 libglade2-0 - library to load .glade files at runtime
 libglade2-dev - development files for libglade
Closes: 290811
Changes:
 libglade2 (1:2.4.2-1) unstable; urgency=medium
 .
   * New upstream release.
     - reverts the handling of old toolbars to the pre-2.4.1 behaviour,
       with the exception of the "active" handling for radio buttons.
       This should not break new packages that use the new toolbar API
       (closes: #290811).
   * debian/patches/01_filechooser: removed, fixed upstream.
Files:
 a1254df2e6a24506cec84b6a610b552a 1558 devel optional libglade2_2.4.2-1.dsc
 c1d1ff86fc9bb7d73fa9d71f8db01c9d 406345 devel optional libglade2_2.4.2.orig.tar.gz
 a53fc84df422798be5078c02b7282429 25986 devel optional libglade2_2.4.2-1.diff.gz
 470d3d6760db6abc42f12de75b9b2a08 82430 libs optional libglade2-0_2.4.2-1_i386.deb
 bdddf63cb9f4be22c0cf7a8dffe1ee1e 124210 libdevel optional libglade2-dev_2.4.2-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCDLONJYSUupF6Il4RAmDlAJ9Alpn7IdoPpVlAQ7ofcu06UdJKjwCeMVA2
aSzNXiUGjaDaVimGez7EKn4=
=QFWk
-----END PGP SIGNATURE-----

Revision history for this message
Sebastien Bacher (seb128) wrote :

works fine on hoary

Changed in libglade2:
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.