OpenLyrics exporter overwrites existing files
Bug #1216232 reported by
Phill
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| OpenLP | Status tracked in Trunk | |||||
| 2.0 |
Won't Fix
|
Undecided
|
Unassigned | |||
| Trunk |
Fix Released
|
Wishlist
|
Tomas Groth | |||
Bug Description
There is two problems with this:
1. We just blindly overwrite any existing files in the export directory
2. If two songs with the same title (but different lyrics) are exported one song overwrites the other.
One solution would be to ask the user if they want to over write, rename or skip with an option to apply to all. (This wouldn't really resolve the issue with same name different lyrics)
Or we could time stamp the file name (Again this wouldn't really resolve the issue with same name different lyrics)
We could also detect if the file exists and increment a counter in the file name. (Probably best combined with the time stamp)
Related branches
lp:~tomasgroth/openlp/bugfixes6
- Raoul Snyman: Approve
- Tim Bentley: Approve
-
Diff: 163 lines (+102/-6)5 files modifiedopenlp/core/ui/settingsdialog.py (+1/-1)
openlp/core/ui/slidecontroller.py (+4/-2)
openlp/plugins/songs/lib/mediaitem.py (+3/-0)
openlp/plugins/songs/lib/openlyricsexport.py (+8/-3)
tests/functional/openlp_plugins/songs/test_openlyricsexport.py (+86/-0)
| tags: | added: song song-export |
Revision history for this message
| Jon (jomenvisst) wrote | #1 |
| summary: |
- OpenLyric exporter overwrites existing files + OpenLyrics exporter overwrites existing files |
To post a comment you must log in.
Another option would be to make a new folder with a time stamp for each export. (Avoids a lot of increments in one folder but could possibly take up slightly more space.)