All parameters are described as "template" in api-ref.html output since 1.9.0 clouddocs-maven-plugin

Bug #1216096 reported by Anne Gentle
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-manuals
Fix Released
Medium
David Cramer

Bug Description

When 1.9.0 was released, the output for api-ref.html added two columns to the parameter descriptions -- one is supposed to be the parameter style and the other the type from the XSD-defined namespace. However the parameter style is always "template" which has a special meaning for some OpenStack APIs.

Tags: doc-builds
Revision history for this message
Tom Fifield (fifieldt) wrote :

I'm also seeing 'header' and 'query'.

Can you clarify what parameter style is supposed to be?

Changed in openstack-manuals:
status: New → Incomplete
tags: added: doc-builds
Revision history for this message
David Cramer (david-thingbag) wrote :

Template parameters are the parts of the url that are replaced, like {tenant_id}.
Query params are the part of the url after the ? like baz in http://foo/bar?baz=10.
Header params are params passed in the http header.
There are also matrix parameters, but I don't understand those yet.

http://www.w3.org/Submission/wadl/#x3-270011

Revision history for this message
Anne Gentle (annegentle) wrote :

In the context of WADL, those definitions are fine. For the context of output from WADL, we need to use another term than template. Is there a way to do that?

Revision history for this message
David Cramer (david-thingbag) wrote :

Yes, we can present it however we like.

Btw., I forgot to mention plain parameters (style="plain"). Those are used to indicate what should be in the request body.

I think Diane has a proposal for this and I have an item in my backlog for it.

Plain params should be a separate table. Maybe each kind of param should be a separate table?

What terms should we use for each kind of param?

query params => query params (I think that's standard)
header params => header params (seems clear enough)
plain params => Maybe don't call them params...just have a table for "Request Body" or whatever.
template params => ????

Revision history for this message
Diane Fleming (diane-fleming) wrote :

query params => query parameters
header params => header parameters
plain params => Request body attributes
template params =>URI parameters

I've added a file - sample_outputs.xml - that shows suggested sample tables.

 https://review.openstack.org/43729

Revision history for this message
Diane Fleming (diane-fleming) wrote :

I added sample outputs to the bk_example.xml file - second to last chapter.

Revision history for this message
Anne Gentle (annegentle) wrote :

Diane's looks good - thanks for the explanation too!

Tom Fifield (fifieldt)
Changed in openstack-manuals:
status: Incomplete → Triaged
importance: Undecided → Medium
milestone: none → havana
Revision history for this message
Diane Fleming (diane-fleming) wrote :

David, I'll open an issue against clouddocs-mvn-plugin -

change "template" parameters to URI parameters.

Changed in openstack-manuals:
assignee: nobody → David Cramer (david-thingbag)
Revision history for this message
David Cramer (david-thingbag) wrote :

Fixed in 1.11.1-SNAPSHOT. We should have a release soon.

Changed in openstack-manuals:
status: Triaged → Fix Committed
Tom Fifield (fifieldt)
Changed in openstack-manuals:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.