coe::site_index errors during initial puppet run of build node

[Daneyon Hansen]

The following error is observed during the initial puppet run of the build node:

err: /Stage[main]/Coe::Site_index/File[/var/www/index.html]/ensure: change from absent to file failed: Could not set 'file on ensure: No such file or directory - /var/www/index.html.puppettmp_5551 at /usr/share/puppet/modules/coe/manifests/site_index.pp:14
err: /Stage[main]/Coe::Site_index/File[/var/www/header-logo.png]/ensure: change from absent to file failed: Could not set 'file on ensure: No such file or directory - /var/www/header-logo.png.puppettmp_6924 at /usr/share/puppet/modules/coe/manifests/site_index.pp:22

This is because the coe::site_index class requires 2 files (index.html and header-logo.png) without first ensuring the directory (/var/www) is created.

[Mark T. Voelker (mvoelker)]

Looks like a timing issue as I haven't observed this. Should be a simple fix.

[Chris Ricker (chris-ricker)]

https://github.com/CiscoSystems/puppet-coe/pull/15

[Mark T. Voelker (mvoelker)]

Hmm...there is one condition on which this fix will break things. If you don't have a $node_gateway set in your site.pp file, then this is a problem:

https://github.com/CiscoSystems/grizzly-manifests/blob/multi-node/manifests/core.pp#L695-L700

Because it causes:

Duplicate definition: File[/var/www] is already defined in file /usr/share/puppet/modules/coe/manifests/site_index.pp at line 29; cannot redefine at /etc/puppet/manifests/core.pp:877 on node cvf2-server-f1.local.lab

(ignore the line number in the error message...I was working off the bp/ha.g2 branch when I noticed this, but the same should apply in multi-node)

That might explain why some of us didn't see this issue in the first place (e.g. because we didn't have a $node_gateway set in our setups).

[Mark T. Voelker (mvoelker)]

Pull to address the second condition:
https://github.com/CiscoSystems/grizzly-manifests/pull/163