Lock remains whilst waiting for SMTP server password to be entered
Bug #121596 reported by
Stuart Colville
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Confirmed
|
Low
|
Unassigned | ||
| bzr email commit hook |
Triaged
|
Low
|
Unassigned | ||
Bug Description
The lock that happens when you commit is not released until the commit plugin has exited.
Not sure if this is down to the commit hooks in bazaar rather than this email plugin but thought it was worth pointing out. The main point is that there's no need for the lock to remain once the commit itself has completed as the success of sending the email of the commit details is not going to affect anything.
Revision history for this message
| Jelmer Vernooij (jelmer) wrote | #1 |
| Changed in bzr-email: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| Changed in bzr: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| tags: | added: hooks |
| Changed in bzr: | |
| status: | Triaged → Confirmed |
| tags: | added: check-for-breezy |
To post a comment you must log in.
The problem is that bzr holds on to the lock while it runs the hooks. bzr-email should either be using another (to be introduced) hook that runs after the lock has been released, or should somehow register a callback that gets called after the lock has been released. Both require some changes in bzr core.