serve-branches doesn't work with file-system paths, causes error 404s
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
loggerhead |
New
|
Undecided
|
Unassigned |
Bug Description
Running serve-branches with a filesystem path (and not using --allow-writes), like this:
$ ./serve-branches ~/bzr
will cause loggerhead not to be able to access the specified path and it will always respond with error 404 over http.
This is because:
1. in loggerhead/main.py, when --allow-writes is not present, "readonly+" is pre-pended to the path to the bzr repos.
E.g., "/home/edam/bzr" becomes "readonly+
2. in loggerhead/
E.g., "readonly+
The result is obviously wrong.
The solution to this seems to be to always specify a full path *and protocol* to the bzr repos. So, in the above example, the server can successfully be run like this:
$ ./serve-branches file://