"HORIZON_IMAGES_ALLOW_UPLOAD = False" does not work

[Jesse Pretorius]

As described in http://docs.openstack.org/developer/horizon/topics/deployment.html#file-uploads it should be possible to set "HORIZON_IMAGES_ALLOW_UPLOAD = False" and the ability for an end-user to upload an image through Horizon should not be available.

However it does not work. I also don't see any evidence in my brief review of the templating code that would take the button/ability away on the "Images & Snapshots" page.

It would be ideal if enabling this would remove the button from the interface, forcing anyone wanting to upload images to use the command-line instead.

[Kieran Spear (kspear)]

HORIZON_IMAGES_ALLOW_UPLOAD exists to disable local uploads, due to the possibility of filling the disk on the dashboard server, since we don't stream uploads to glance/swift yet. It removes the "Image File" field from the Create Image dialog. It was not meant to disable image creation altogether as image creation via URL doesn't have the issue that direct uploads does.

[Lawrance (jing)]

hi, Gabriel :
are you still active in the bug?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/48554

[Gabriel Hurley (gabriel-hurley)]

My current feeling is that the fetaure behaves as originally intended, though the meaning of it is evidently confusing.

In Icehouse, as part of the ongoing RBAC work, we should be able to make these actions individually controllable so that allowing or disallowing image upload entirely can be controlled on a per-role or global basis.

[David Lapsley (dlapsley)]

Hi Folks: is there anything left to be done here? Doc update to avoid confusion?

Cheers, Dave.

[Jesse Pretorius (jesse-pretorius)]

@dlapsley I don't know where the RBAC work is at - perhaps this is serving as some sort of reminder in that chain of work? Otherwise a doc update would suffice IMO.

[Julie Pichon (jpichon)]

Unassigning due to long time without activity. It sounds like the bug is about updating the documentation at http://docs.openstack.org/developer/horizon/topics/settings.html in order to make the meaning of HORIZON_IMAGES_ALLOW_UPLOAD clearer.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/80346

[Openstack Gerrit (openstack-gerrit)]

Fix proposed to branch: master
Review: https://review.openstack.org/89276

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/80346
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a7bd91d7d88a8408929f0f7e580bec83fa3effdb
Submitter: Jenkins
Branch: master

commit a7bd91d7d88a8408929f0f7e580bec83fa3effdb
Author: Anya Marshall <email address hidden>
Date: Wed Mar 12 19:52:10 2014 -0400

    Update documentation to clarify Image Upload setting

    The documentation at http://docs.openstack.org/developer/horizon/topics
    /deployment.html#file-uploads states that the end user should change the
    setting "HORIZON_IMAGES_ALLOW_UPLOAD = False" to disable image uploads.

    This suggests that image uploads will be completely disabled, however it
    will still be possible to upload images via URL.

    This change adds this clarification to the documentation.

    Closes-Bug: 1215921
    Change-Id: Ie1cc51aaf459f9eb2881121b405fb16e762e265b