Launchpad 'build revision' footer is confusing

Bug #121563 reported by Barry Warsaw
16
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Joey Stanford

Bug Description

On the footer of all Launchpad pages, you see next to the copyright notice, the words 'build 4412' (as of today). This is confusing and a bit misleading in the face of cherrypicks though, because Launchpad isn't exactly running r4412. It would be better to describe the release version number, e.g. 'version 1.1.6'.

Rinchen points out in irc that the build number was used to troubleshoot mismatched appservers at one point, but even there, in the face of cherrypicks, the footer text is misleading.

Revision history for this message
Barry Warsaw (barry) wrote :

Oh, it might be cool if the 'version 1.1.6' were a hyperlink to a What's New help page.

Revision history for this message
Tom Haddon (mthaddon) wrote :

I think this makes total sense for the production servers, but I think for demo/staging/edge it's good to preserve the bzr version number.

Incidentally, Launchpad is running revision 4412 - this is the revision number of the branch it's running (production/1.89) which gets that number from me branching from 4411 and then applying three cherry picks in one commit.

Revision history for this message
Diogo Matsubara (matsubara) wrote :

How about that being a link accessible only to members of lp-dev team to the codebrowse instance on devpad?

Changed in launchpad:
status: New → Confirmed
Revision history for this message
Tom Haddon (mthaddon) wrote :

In a duplicate bug report it was mentioned that those being redirected to edge might find the revision number useful since sometimes bug reports mention which revision a particular fix was made available in.

Therefore it might make sense to preserve the build number on edge (since this is the revision of the devel branch itself), but only make it a link as specified above to members of the lp-dev team. On lpnet itself, having the release number still makes most sense.

Revision history for this message
Joey Stanford (joey) wrote :

At today's Launchpad meeting we agreed to modify this so it reads "© 2004-2008 Canonical Ltd. | Version 1.2.2 revision 5722".

I am thinking of perhaps updating this right after PQM opens each cycle so that edge will always read current version +1 to match the site message on edge which says "this is test code".

e.g.

Production: "© 2004-2008 Canonical Ltd. | Version 1.2.2 revision 5722"
Edge and Staging: "© 2004-2008 Canonical Ltd. | Version 1.2.3 revision 5753"
Demo: "© 2004-2008 Canonical Ltd. | Version 1.2.1 revision 5623" (or whenever this get's updated)

I've email mpt for his opinions before I finalize the process and code.

Changed in launchpad:
assignee: nobody → rinchen
importance: Undecided → Low
milestone: none → 1.2.3
Revision history for this message
Joey Stanford (joey) wrote :

another way to do this is to modify the edge (and maybe staging) configs to include a "is_edge true" flag and then customize the tal in main-template to recognize this such that edge produces something like:

"© 2004-2008 Canonical Ltd. | Version pre-1.2.3 revision 5753"

also my comments about demo above are incorrect. There is a tal condition for demo which puts appends DEMO to it.
So it would read: "Copyright 2004-2007 Canonical Ltd. | Version 1.1.11 revision 5381 | DEMO"

if we want to follow the same convention then edge might look like

"© 2004-2008 Canonical Ltd. | Version 1.2.3 revision 5753 | EDGE"

Revision history for this message
Joey Stanford (joey) wrote :
Revision history for this message
Joey Stanford (joey) wrote :

beta available. Sent to Stu, Tom, and Curtis for spot checks since I'm changing config files.

Changed in launchpad:
status: Confirmed → In Progress
Revision history for this message
Joey Stanford (joey) wrote :

in RF 5757 on 26 Feb.

Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Joey Stanford (joey) wrote :

added linkification to the help wiki in RF 5836

Joey Stanford (joey)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.