sync-source aborts with ForbiddenAttribute

[Martin Pitt]

Since today's LP rollout, sync-source does not work any more:

$ sync-source -b stevenk -f xapian-bindings
Traceback (most recent call last):
  File "/home/lp_archive/bin/sync-source", line 1602, in ?
    main()
  File "/home/lp_archive/bin/sync-source", line 1588, in main
    arguments = init()
  File "/home/lp_archive/bin/sync-source", line 1567, in init
    objectize_options()
  File "/home/lp_archive/bin/sync-source", line 1521, in objectize_options
    Options.tosuite = Options.todistro.currentrelease.name
zope.security.interfaces.ForbiddenAttribute: ('currentrelease', <Distribution at 0x2aaab2908f10>)

and it's not only currentrelease, if I try to circumvent it, it still fails:

$ sync-source -s gutsy -b stevenk -f xapian-bindings
Traceback (most recent call last):
  File "/home/lp_archive/bin/sync-source", line 1602, in ?
    main()
  File "/home/lp_archive/bin/sync-source", line 1588, in main
    arguments = init()
  File "/home/lp_archive/bin/sync-source", line 1567, in init
    objectize_options()
  File "/home/lp_archive/bin/sync-source", line 1522, in objectize_options
    Options.tosuite = Options.todistro.getRelease(Options.tosuite)
zope.security.interfaces.ForbiddenAttribute: ('getRelease', <Distribution at 0x2aaab2908f10>)

[Julian Edwards (julian-edwards)]

sync-source is still using currentrelease instead of currentseries.

This should have been renamed in Mark's big change from distrorelease to distroseries, I don't know why it got missed.

[Colin Watson (cjwatson)]

I've fixed this in place in ~lp_archive/bin/sync-source, although the version in RF (or at least the one in codelines/current/) needs to be fixed too.

[Martin Pitt (pitti)]

remove-package.py suffers from the same bug. I recommend a thorough grep -r currentrelease in RF :-)

[Celso Providelo (cprov)]

{{{
$grep -n 'currentrelease' -r scripts/
scripts/ftpmaster-tools/archive-cruft-check.py:297: Options.distrorelease = Options.distro.currentrelease.name
scripts/ftpmaster-tools/remove-package.py:270: Options.suite = Options.distro.currentrelease.name
scripts/ftpmaster-tools/sync-source.py:1239: Options.target_suite = Options.target_distro.currentrelease.name
}}}

IFW, they were missed because: 1 - they live in a very unexpected place; 2 - they are not covered by tests.

[Jonathan Riddell (jr)]

backports-source has the same issue

[Celso Providelo (cprov)]

Needs in-place fix

[Celso Providelo (cprov)]

backport-source is not even in RF.

[Celso Providelo (cprov)]

Changes applied in production launchpad-tree, pending migration to scritps outside RF (as backport-source and sync-source).
Changes are going to be merge ASAP in RF and cherrypicked in production officially.

[Celso Providelo (cprov)]

RF 4439

[Martin Pitt (pitti)]

This affects archive-cruft-check.py as well:

$ archive-cruft-check.py -n
Traceback (most recent call last):
  File "/srv/launchpad.net/codelines/current/scripts/ftpmaster-tools/archive-cruft-check.py", line 23, in ?
    from canonical.launchpad.database import DistroArchReleaseBinaryPackage
ImportError: cannot import name DistroArchReleaseBinaryPackage

This is DistroArchSeriesBinaryPackage now.

[Celso Providelo (cprov)]

further fixes will be applied via bug 121784.

[Celso Providelo (cprov)]

Despite of not solving the problem entirely