The powervm driver should log ssh stderr as warning rather than debug

Bug #1215019 reported by Matt Riedemann
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Subashini Soundararajan

Bug Description

There are 4 methods in the powervm driver that run ssh calls to the backing hypervisor (2 in blockdev, 2 in operator) and check for stderr output but only log it at debug level, which could be masking more serious issues. The stderr results should be logged at warning instead.

https://github.com/openstack/nova/blob/master/nova/virt/powervm/blockdev.py#L563
https://github.com/openstack/nova/blob/master/nova/virt/powervm/blockdev.py#L580

https://github.com/openstack/nova/blob/master/nova/virt/powervm/operator.py#L694
https://github.com/openstack/nova/blob/master/nova/virt/powervm/operator.py#L711

Mathew Odden (locke105)
Changed in nova:
status: New → Incomplete
status: Incomplete → Confirmed
Changed in nova:
assignee: nobody → Subashini Soundararajan (subashini-rajan17)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43651

Changed in nova:
status: Confirmed → In Progress
Changed in nova:
assignee: Subashini Soundararajan (subashini-rajan17) → Sameer Adhikari (tri2sing)
Changed in nova:
assignee: Sameer Adhikari (tri2sing) → Subashini Soundararajan (subashini-rajan17)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/43651
Committed: http://github.com/openstack/nova/commit/43e102cc215aabc72a0ef84cf48965c4db2d58d4
Submitter: Jenkins
Branch: master

commit 43e102cc215aabc72a0ef84cf48965c4db2d58d4
Author: Subashini Soundararajan <email address hidden>
Date: Mon Aug 26 17:58:26 2013 -0700

    Powervm driver now logs ssh stderr to warning

    The run_vios_command, run_vios_command_as_root methods in
    blockdevice.py and operator.py of powervm driver currently log
    stderr at debug level, this commit changed it to log to warning
    level rather than debug.

    Closes-Bug: #1215019
    Change-Id: I903067476049ead01c6c34392342d915917790b3

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.