Checkbox

implementation of resume functionality required

Bug #1214896 reported by Chris Gregan
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
High
Zygmunt Krynicki
Checkbox plainbox-0.4b1

Bug Description

DBus API is complete but needs to be used by the application. Some bugs in the implementation of plainbox prevent the service from working correctly upon resume.

See original description
Tags: plainbox

Related branches

lp:~zyga/checkbox/dbus-resume
Rejected for merging into lp:checkbox
Checkbox Developers: Pending requested
Diff: 1048 lines (+475/-190)
10 files modified
plainbox/plainbox/impl/dbus/decorators.py (+16/-1)
plainbox/plainbox/impl/dbus/service.py (+4/-1)
plainbox/plainbox/impl/job.py (+2/-2)
plainbox/plainbox/impl/result.py (+16/-3)
plainbox/plainbox/impl/service.py (+328/-153)
plainbox/plainbox/impl/session/jobs.py (+2/-2)
plainbox/plainbox/impl/session/legacy.py (+2/-10)
plainbox/plainbox/impl/session/resume.py (+6/-2)
plainbox/plainbox/impl/session/state.py (+7/-16)
plainbox/plainbox/impl/session/test_manager.py (+92/-0)
lp:~andrew-haigh-b/cdts/refactor_bug1214896
Daniel Manrique (community): Approve
Diff: 1868 lines (+1180/-160)
22 files modified
plainbox-gui/canonical-driver-test-suite/WhiteListModelFactory.cpp (+71/-0)
plainbox-gui/canonical-driver-test-suite/WhiteListModelFactory.h (+42/-0)
plainbox-gui/canonical-driver-test-suite/canonical-driver-test-suite.pro (+4/-2)
plainbox-gui/canonical-driver-test-suite/main.cpp (+56/-76)
plainbox-gui/canonical-driver-test-suite/qml/ResumeView.qml (+31/-4)
plainbox-gui/canonical-driver-test-suite/qml/RunManagerButtons.qml (+3/-0)
plainbox-gui/canonical-driver-test-suite/qml/RunManagerListView.qml (+4/-0)
plainbox-gui/canonical-driver-test-suite/qml/TestSelectionListView.qml (+6/-0)
plainbox-gui/canonical-driver-test-suite/qml/TestSelectionView.qml (+1/-3)
plainbox-gui/canonical-driver-test-suite/qml/WelcomeView.qml (+7/-1)
plainbox-gui/canonical-driver-test-suite/qml/canonical-driver-test-suite.qml (+9/-1)
plainbox-gui/canonical-driver-test-suite/testitemmodel.cpp (+76/-4)
plainbox-gui/canonical-driver-test-suite/testitemmodel.h (+6/-0)
plainbox-gui/canonical-driver-test-suite/whitelistitem.h (+5/-0)
plainbox-gui/gui-engine/PBJsonUtils.cpp (+71/-0)
plainbox-gui/gui-engine/PBJsonUtils.h (+38/-0)
plainbox-gui/gui-engine/PBNames.h (+3/-0)
plainbox-gui/gui-engine/PBTreeNode.cpp (+16/-0)
plainbox-gui/gui-engine/PBTreeNode.h (+3/-0)
plainbox-gui/gui-engine/gui-engine.cpp (+648/-67)
plainbox-gui/gui-engine/gui-engine.h (+76/-0)
plainbox-gui/gui-engine/gui-engine.pro (+4/-2)
Chris Gregan (cgregan)
Changed in checkbox-ihv-ng:
status: New → Confirmed
importance: Undecided → Critical
milestone: none → version1.0
Andrew Haigh (andrew-haigh-b)
Changed in checkbox-ihv-ng:
assignee: nobody → Andrew Haigh (andrew-haigh-b)
Revision history for this message
Andrew Haigh (andrew-haigh-b) wrote :

Note the linked bugfix branch is currently work in progress, the session save functionality is there, and it correctly identifies the potential for resuming a cancelled run. But the actual recreation and resumption of the run is yet to be done.

Zygmunt Krynicki (zyga)
Changed in checkbox:
assignee: nobody → Zygmunt Krynicki (zkrynicki)
importance: Undecided → High
status: New → In Progress
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I found a simple typo that prevented resume from working with dbus (again), pushed a fix for that to my working branch. I've also requested feedback on the implementation in the associated merge request. I'm going to test if it works with the branch Andrew has posted and get back with the feedback here.

Changed in checkbox-ihv-ng:
status: Confirmed → In Progress
description: updated
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

It's broken and it's my fault. I know what the problem is (legacy.py) but I cannot fix it tonight. VERY interesting problem, sadly.

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I've fixed it, the solution came to me this morning and was so easy and elegant I just had to write it. I'll clean up commit history and propose this tomorrow.

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

This is now actually implemented, both in the python and dbus layers

Changed in checkbox:
status: In Progress → Fix Committed
Daniel Manrique (roadmr)
tags: added: plainbox
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

What needs to be done to close this bug, multi-session management or is it out of scope?

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I think this is implemented now.

Changed in checkbox-ihv-ng:
status: In Progress → Fix Committed
Sylvain Pineau (sylvain-pineau)
Changed in checkbox-ihv-ng:
status: Fix Committed → Fix Released
Zygmunt Krynicki (zyga)
Changed in checkbox:
status: Fix Committed → Fix Released
milestone: none → plainbox-0.4b1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.