ipdiscover-util.pl patch to remove registered hosts and add Mac support

[Daniel Rich]

(originally posted in the forums at: http://forums.ocsinventory-ng.org/viewtopic.php?id=13195)

One of the things that has always bugged me about ipdiscover-util and the analyze button is that it gives me hosts that include the ones I have already registered. This can be fixed by updating the SELECT statement at line 374 to restrict it to hosts that aren't already in the network_devices table. The new line would look like:
  $request = $dbh->prepare('SELECT IP,MASK,MAC,DATE FROM netmap LEFT JOIN networks ON MACADDR=MAC where MACADDR IS NULL AND MAC NOT IN (SELECT MACADDR FROM network_devices)');

There is also an issue where the error message numbers that ipdiscover-util returns are always "345", the patch below also addresses that issue. The patch also include code to allow the proper recognition of Mac systems and a fix for the nmap parsing (I'm not sure that will work for everyone, but it is needed with nmap 6.25).

[mortheres (mortheres)]

Hi,

Thanks a lot for your patch. It has been integrated in revision 717 of the lp:ocsinventory-server/stable-2.1 branch: http://bazaar.launchpad.net/~ocsinventory-dev/ocsinventory-server/stable-2.1/revision/717

It will be included in final OCS 2.1 release :D :D.

Kind regards,

--
Guillaume