cinder create volume failure when source volume 'in-use'

[Alan Jiang]

https://review.openstack.org/#/c/29862/ introduced a volume state checking during create volume.

When trying to clone a volume by using create volume from source volume function, the create failed
since the source volume is in the 'in-use' state. The original create_volume by source volume function
from cinder.volume.manager doesn't have such state check.

Our use case requires the source volume to stay attached to Nova instance while doing the clone. The operating
system running will ensure the consistency of the volume that is cloned from. This will be a typical use case
for the FibreChannel attached storage environment.

I would like to get the original error only state checking behavior back before we introduce a new
state to handle this case.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/42809

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/42809
Committed: http://github.com/openstack/cinder/commit/ab29496714296161ce60b3cd59b85289c3f8889e
Submitter: Jenkins
Branch: master

commit ab29496714296161ce60b3cd59b85289c3f8889e
Author: Alan Jiang <email address hidden>
Date: Tue Aug 20 00:22:44 2013 -0500

    Allow volume create from source unless in error status

    This patch restores the source volume status checking behavior
    to allow create_volume function to proceed unless it is in
    error status. In FibreChannel attached environment, it is typical
    to have a volume attached before the volume clone starts. The
    operating system owns the volume will ensure the consistency.

    Fixes: bug #1214235
    Change-Id: Ie639f2f36e2939399303ca0658c169124801e86b