naming test script 'run.sh' overwrites the script that runs the test

[Milosz Wasilewski]

If the script named 'run.sh' is downloaded before the test starts it overwrites the default test execution script. This is however a corner case and it should be enough to document the 'forbidden names' to warn users. Example yaml file that causes the problem:

metadata:
    name: passfail
    format: "Lava-Test-Shell Test Definition 1.0"
    description: "Pass/Fail test."

install:
    steps:
        - wget http://10.0.0.1/foo/test/run.sh -O test_run.sh
        - chmod +x test_run.sh

run:
    steps:
        - ./test_run.sh

parse:
    pattern: "(?P<test_case_id>[a-zA-Z0-9_-]+):\\s(?P<result>\\w+)"

[Antonio Terceiro (terceiro)]

On Mon, Aug 19, 2013 at 01:37:21PM -0000, Milosz Wasilewski wrote:
> If the script named 'run.sh' is downloaded before the test starts it
> overwrites the default test execution script. This is however a corner
> case and it should be enough to document the 'forbidden names' to warn
> users. Example yaml file that causes the problem:
[...]
> install:
> steps:
> - wget http://10.0.0.1/foo/test/run.sh -O test_run.sh
> - chmod +x test_run.sh

I'm confused: you are not writing run.sh. To me it seems that this yaml
file *works around* the reported problem, instead of exposing it ... am
I missing something?

[Milosz Wasilewski (mwasilew)]

On 19 August 2013 20:37, Antonio Terceiro <email address hidden> wrote:
> On Mon, Aug 19, 2013 at 01:37:21PM -0000, Milosz Wasilewski wrote:
>> If the script named 'run.sh' is downloaded before the test starts it
>> overwrites the default test execution script. This is however a corner
>> case and it should be enough to document the 'forbidden names' to warn
>> users. Example yaml file that causes the problem:
> [...]
>> install:
>> steps:
>> - wget http://10.0.0.1/foo/test/run.sh -O test_run.sh
>> - chmod +x test_run.sh
>
> I'm confused: you are not writing run.sh. To me it seems that this yaml
> file *works around* the reported problem, instead of exposing it ... am
> I missing something?
>

copy/paste mistake in the bug. I pasted the yaml that works around the
problem :)
Yaml that caused the problem was like this:

install:
     steps:
         - wget http://10.0.0.1/foo/test/run.sh
         - chmod +x test_run.sh

[Dave Pigott (dpigott)]

We should not be downloading to the test directory

[Antonio Terceiro (terceiro)]

actually we should never write *anything* to the directory where the test definition is located

[Tyler Baker (tyler-baker)]

Any thoughts on a way forward on this issue?